summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz@archlinux.org>2019-10-07 23:18:11 +0200
committerAllan McRae <allan@archlinux.org>2019-10-09 07:39:48 +0200
commita897599fa54813ea2a225271eacd9fb6e1a6762e (patch)
treec13ebb4b2884365c10551d2e40fc233766cee409 /scripts
parente8d4228614e4f45f74a5233eb7a322494429fd22 (diff)
downloadpacman-a897599fa54813ea2a225271eacd9fb6e1a6762e.tar.gz
pacman-a897599fa54813ea2a225271eacd9fb6e1a6762e.tar.xz
makepkg: do not save fflags when creating packages
Saving fflages breaks reproducible builds due to encoding information specific to the filesystem that was used to build the package. This information is not needed for packaging purposes anyway. Including fflags also means that attempting to extract a package file as root (or fakeroot) might result in angry warnings being printed to the console by bsdtar, followed by a non-zero exit code, unless the user remembers to use --no-fflags during extraction. This is unpleasant UI, even if pacman itself won't care about these. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/makepkg.sh.in4
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index dae025c9..e134200f 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -719,7 +719,7 @@ create_package() {
msg2 "$(gettext "Compressing package...")"
# TODO: Maybe this can be set globally for robustness
shopt -s -o pipefail
- list_package_files | LANG=C bsdtar -cnf - --null --files-from - |
+ list_package_files | LANG=C bsdtar --no-fflags -cnf - --null --files-from - |
compress_as "$PKGEXT" > "${pkg_file}" || ret=$?
shopt -u -o pipefail
@@ -810,7 +810,7 @@ create_srcpackage() {
# TODO: Maybe this can be set globally for robustness
shopt -s -o pipefail
- LANG=C bsdtar -cLf - ${pkgbase} | compress_as "$SRCEXT" > "${pkg_file}" || ret=$?
+ LANG=C bsdtar --no-fflags -cLf - ${pkgbase} | compress_as "$SRCEXT" > "${pkg_file}" || ret=$?
shopt -u -o pipefail