summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAndrew Gregory <andrew.gregory.8@gmail.com>2017-05-11 00:54:56 +0200
committerAllan McRae <allan@archlinux.org>2017-05-16 04:43:17 +0200
commit63087c31b5bdd7a16d312d9bf938f6cfd4a635b0 (patch)
tree04afced797a7c357ce6dba1602dfb61313737ed9 /src
parenta2b776f6c901c706946b49d2b5cadb0c6efd2655 (diff)
downloadpacman-63087c31b5bdd7a16d312d9bf938f6cfd4a635b0.tar.gz
pacman-63087c31b5bdd7a16d312d9bf938f6cfd4a635b0.tar.xz
check for overflow when setting HTTP_USER_AGENT
gcc7 issues a warning about a potential overflow if left unchecked. Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'src')
-rw-r--r--src/pacman/pacman.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
index 605aec3e..11b7e6f0 100644
--- a/src/pacman/pacman.c
+++ b/src/pacman/pacman.c
@@ -271,10 +271,15 @@ static void setuseragent(void)
{
char agent[101];
struct utsname un;
+ int len;
uname(&un);
- snprintf(agent, 100, "pacman/%s (%s %s) libalpm/%s",
+ len = snprintf(agent, 100, "pacman/%s (%s %s) libalpm/%s",
PACKAGE_VERSION, un.sysname, un.machine, alpm_version());
+ if(len >= 100) {
+ pm_printf(ALPM_LOG_WARNING, _("HTTP_USER_AGENT truncated\n"));
+ }
+
setenv("HTTP_USER_AGENT", agent, 0);
}