From 008fe7b24fded17e4a1a235885057263a3dc413a Mon Sep 17 00:00:00 2001 From: Allan McRae Date: Wed, 4 Jan 2017 15:24:23 +1000 Subject: Fix memory leak in alpm_pkg_checkmd5sum Also remove redundant additional return path. Signed-off-by: Allan McRae --- lib/libalpm/package.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c index d0f902f0..e9ecc178 100644 --- a/lib/libalpm/package.c +++ b/lib/libalpm/package.c @@ -69,9 +69,9 @@ int SYMEXPORT alpm_pkg_checkmd5sum(alpm_pkg_t *pkg) retval = _alpm_test_checksum(fpath, pkg->md5sum, ALPM_PKG_VALIDATION_MD5SUM); - if(retval == 0) { - return 0; - } else if(retval == 1) { + FREE(fpath); + + if(retval == 1) { pkg->handle->pm_errno = ALPM_ERR_PKG_INVALID; retval = -1; } -- cgit v1.2.3-24-g4f1b