From 3b0ae4f049b7a357f9b2c8ac0c2f9af88155760e Mon Sep 17 00:00:00 2001 From: Florian Pritz Date: Fri, 12 May 2017 08:37:15 +0200 Subject: remove full file loading code This actually makes everything slower (base base-devel 2sec vs 1.4 normally) Signed-off-by: Florian Pritz --- lib/libalpm/signing.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/lib/libalpm/signing.c b/lib/libalpm/signing.c index cf93fa2b..b7587d1c 100644 --- a/lib/libalpm/signing.c +++ b/lib/libalpm/signing.c @@ -543,30 +543,11 @@ int _alpm_gpgme_checksig(alpm_handle_t *handle, const char *path, memset(&sigdata, 0, sizeof(sigdata)); memset(&filedata, 0, sizeof(filedata)); - char* filecontent; - struct stat statbuf; - - // TODO check return code - stat(path, &statbuf); - - size_t filesize = statbuf.st_size; - - filecontent = malloc(filesize); - if (filecontent == NULL) { - printf("Failed to allocate memory\n"); - goto error; - } - - if (fread(filecontent, filesize, 1, file) != 1) { - // TODO error handling - } - gpg_err = gpgme_new(&ctx); CHECK_ERR(); /* create our necessary data objects to verify the signature */ - //gpg_err = gpgme_data_new_from_stream(&filedata, file); - gpg_err = gpgme_data_new_from_mem(&filedata, filecontent, filesize, 1); + gpg_err = gpgme_data_new_from_stream(&filedata, file); CHECK_ERR(); /* next create data object for the signature */ -- cgit v1.2.3-24-g4f1b