From ae5cf26b5b5b92c9f68b5b29787e7d636f334c12 Mon Sep 17 00:00:00 2001 From: Allan McRae Date: Thu, 24 Oct 2019 23:38:50 +1000 Subject: Fix segfault importing PGP key for pacman -U operations Use after free. Signed-off-by: Allan McRae --- lib/libalpm/be_package.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libalpm/be_package.c b/lib/libalpm/be_package.c index 0f45c331..5ffea875 100644 --- a/lib/libalpm/be_package.c +++ b/lib/libalpm/be_package.c @@ -760,14 +760,14 @@ int SYMEXPORT alpm_pkg_load(alpm_handle_t *handle, const char *filename, int ful pkg_temp = _alpm_pkg_load_internal(handle, filename, full); if(pkg_temp) { packager = pkg_temp->packager; - _alpm_pkg_free(pkg_temp); + } else { packager = NULL; } if(_alpm_key_import(handle, packager, key) == -1) { fail = 1; } - free(packager); + _alpm_pkg_free(pkg_temp); } } FREELIST(keys); -- cgit v1.2.3-24-g4f1b