From de8c5e78bbaec3aea16523d1a7c5cc6801154c80 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Thu, 31 May 2018 20:31:23 -0400 Subject: libmakepkg/lint_pkgbuild: squelch syntax error when a pkgname is empty We fail with an error, but then we also fail with: ==> ERROR: depends is not allowed to be empty. /usr/share/makepkg/lint_pkgbuild/pkgname.sh: line 39: continue: only meaningful in a `for', `while', or `until' loop During the refactor to provide enhanced pkgname=pkgver linting, this was moved out of the ${pkgname[@]} loop to a distinct function, at which time it should have been modified to return rather than continue. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae --- scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in b/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in index d51c6313..84666a29 100644 --- a/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in +++ b/scripts/libmakepkg/lint_pkgbuild/pkgname.sh.in @@ -35,8 +35,7 @@ lint_one_pkgname() { if [[ -z $name ]]; then error "$(gettext "%s is not allowed to be empty.")" "$type" - ret=1 - continue + return 1 fi if [[ ${name:0:1} = "-" ]]; then error "$(gettext "%s is not allowed to start with a hyphen.")" "$type" -- cgit v1.2.3-24-g4f1b