From 869e81e1cf115e835040d0ecadb6108880103abe Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Mon, 5 Mar 2007 22:13:33 +0000 Subject: This commit looks much more monumental than it is. Almost all just #include reordering and adding ones that were forgotten (noticed when trying to compile after reordering). * Updated the HACKING file to include information on #include usage. * print -> vprint in "making dir" function in pactest. --- HACKING | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) (limited to 'HACKING') diff --git a/HACKING b/HACKING index 9d8681cc..ea8936db 100644 --- a/HACKING +++ b/HACKING @@ -1,8 +1,8 @@ Contributing to pacman ====================== -Please read 'submitting-patches' and 'translation-help' in the same directory as -this file. +Please read 'submitting-patches' and 'translation-help' in the same directory +as this file. Coding style ------------ @@ -62,4 +62,34 @@ Coding style NOT sizeof(*mylist); +Other Concerns +-------------- + +Currently our #include usage is in messy shape, but this is no reason to +continue down this messy path. When adding an include to a file, follow this +general pattern, including blank lines: + +#include "config.h" + +#include +#include +#include <...> + +Follow this with some more headers, depending on whether the file is in libalpm +or pacman proper. For libalpm: + +/* libalpm */ +#include "yourfile.h" +#include "alpm_list.h" +#include "anythingelse.h" + +For pacman: + +#include +#include + +/* pacman */ +#include "yourfile.h" +#include "anythingelse.h" + vim: set ts=2 sw=2 et: -- cgit v1.2.3-24-g4f1b