From 076b6184de2b20e9b26225d93f6f3a7030504109 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Thu, 3 May 2018 00:10:21 -0400 Subject: Ensure better text editor automatic filetype detection Since we no longer use vim-specific modelines, use the .asciidoc file extension which is, well, reserved for asciidoc formatted files. This should presumably work everywhere without needing editor-specific workarounds and configuration. Also add a shebang to makepkg.conf to indicate it contains bash content. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae --- doc/submitting-patches.txt | 101 --------------------------------------------- 1 file changed, 101 deletions(-) delete mode 100644 doc/submitting-patches.txt (limited to 'doc/submitting-patches.txt') diff --git a/doc/submitting-patches.txt b/doc/submitting-patches.txt deleted file mode 100644 index 73c7487d..00000000 --- a/doc/submitting-patches.txt +++ /dev/null @@ -1,101 +0,0 @@ -Pacman - Submitting Patches -=========================== - -This document is here mainly to make the job of those who review patches -easier and is more of a guideline and not a strict set of rules. However, -please try to follow as much as you can. - -NOTE: Some of this is paraphrased from the kernel documentation's -"SubmittingPatches" file. - - -Getting the most recent source ------------------------------- -Patches need to be submitted in GIT format and are best if they are against the -latest version of the code. There are several helpful tutorials for getting -started with GIT if you have not worked with it before. - -* https://www.kernel.org/pub/software/scm/git/docs/gittutorial.html -* https://wiki.archlinux.org/index.php/Super_Quick_Git_Guide - -The pacman code can be fetched using the following command: - - git clone git://projects.archlinux.org/pacman.git - - -Creating your patch -------------------- - --- -* Use `git commit -s` for creating a commit of your changes. - -The -s allows you to credit yourself by adding a "Signed Off By" line to -indicate who has "signed" the patch - who has approved it. - - Signed-off-by: Aaron Griffin - -Please use your real name and email address. Feel free to "scramble" the -address if you're afraid of spam. - -* Describe your patch. - -It helps if you describe the overview and goals of the patch in the git commit -log. This allows others to see what you intended so as to compare it to what -was actually done, and allows better feedback. - -* Use `git format-patch` to create patches. - -Your commit message will be shown above the patch by default when you will use -`git format-patch`, including the signoff line. Sets of multiple patches that -need extra explanation beyond the commit messages may include additional notes -in a cover letter. Individual patches may include additional notes between the -"---" following the commit message and the beginning of the diff. - --- - -Submitting your patch ---------------------- - --- -* Send the patch to the pacman-dev mailing list - -The mailing list is the primary queue for review and acceptance. Here you -will get feedback, and let the reviewers know the details of your patch. - -* No MIME, no links, no compression, no attachments. Just plain text. - -Patches should be contained in the actual body of the email. There are many -reasons for this. First, it makes them easier to read with any mail reader, -it allows easier review "at a glance", and most importantly, it allows people -to comment on exact lines of the patch in reply emails. - -`git send-email` allows you to send Git-formatted patches in plain text easily -and is the preferred method for submission to the mailing list. Mail clients, -including Gmail's web interface, have a tendency to break patches by wrapping -lines and/or adjusting whitespace and should be avoided. - --- - -After you submit ----------------- - --- -* Don't get discouraged - -Any feedback you get, positive or negative, has nothing to do with you. If a -patch is rejected, try taking the suggestions into account and re-submitting. -We welcome most submissions here, and some may take a bit longer to get -looked over than others. If you think your patch got lost in the shuffle, -send another email to the list in reply to the original asking if anyone has -looked at it yet. - -* Respond to feedback - -When you do get feedback, it usually merits a response, whether this be a -resubmission of the patch with corrections or a follow-up email asking for -clarifications. When neither of these occurs, don't expect your patch to get -further review. The all-volunteer staff don't have time to fix up patches that -aren't their own. When resubmitting patches, update the subject line to reflect -the version number ('[PATCHv2]'), and send it as a reply to the original thread. - --- -- cgit v1.2.3-24-g4f1b