From 24324ff0e12a3e19cada669a4c5c391e486790a3 Mon Sep 17 00:00:00 2001 From: Allan McRae Date: Mon, 4 Jul 2011 11:17:12 +1000 Subject: Simplify alpm_list_previous We can readily detect the first node in a list by checking if node->prev->next is NULL. So there is no need to pass the head of the list to this function and its prototype now looks like all the other item accessors. Signed-off-by: Allan McRae Signed-off-by: Dan McGee --- lib/libalpm/alpm_list.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'lib/libalpm/alpm_list.c') diff --git a/lib/libalpm/alpm_list.c b/lib/libalpm/alpm_list.c index 38cefa62..071cd994 100644 --- a/lib/libalpm/alpm_list.c +++ b/lib/libalpm/alpm_list.c @@ -547,11 +547,10 @@ inline alpm_list_t SYMEXPORT *alpm_list_next(const alpm_list_t *node) * * @return the previous element, or NULL when no previous element exist */ -inline alpm_list_t SYMEXPORT *alpm_list_previous(const alpm_list_t *list, - const alpm_list_t *node) +inline alpm_list_t SYMEXPORT *alpm_list_previous(const alpm_list_t *list) { - if(node && node != list) { - return node->prev; + if(list && list->prev->next) { + return list->prev; } else { return NULL; } -- cgit v1.2.3-24-g4f1b