From bf06efaa7831d9c18d6687f197303a688d843ca9 Mon Sep 17 00:00:00 2001 From: Allan McRae Date: Sun, 21 Dec 2014 23:45:24 +1000 Subject: _alpm_delta_dup: free memory on error Signed-off-by: Allan McRae --- lib/libalpm/delta.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'lib/libalpm/delta.c') diff --git a/lib/libalpm/delta.c b/lib/libalpm/delta.c index baa02b75..23ca31d5 100644 --- a/lib/libalpm/delta.c +++ b/lib/libalpm/delta.c @@ -342,14 +342,18 @@ alpm_delta_t *_alpm_delta_dup(const alpm_delta_t *delta) { alpm_delta_t *newdelta; CALLOC(newdelta, 1, sizeof(alpm_delta_t), return NULL); - STRDUP(newdelta->delta, delta->delta, return NULL); - STRDUP(newdelta->delta_md5, delta->delta_md5, return NULL); - STRDUP(newdelta->from, delta->from, return NULL); - STRDUP(newdelta->to, delta->to, return NULL); + STRDUP(newdelta->delta, delta->delta, goto error); + STRDUP(newdelta->delta_md5, delta->delta_md5, goto error); + STRDUP(newdelta->from, delta->from, goto error); + STRDUP(newdelta->to, delta->to, goto error); newdelta->delta_size = delta->delta_size; newdelta->download_size = delta->download_size; return newdelta; + +error: + _alpm_delta_free(newdelta); + return NULL; } /* vim: set noet: */ -- cgit v1.2.3-24-g4f1b