From 72c5a298a3ee0f18019010ef2eb43da654ec25f8 Mon Sep 17 00:00:00 2001 From: Xavier Chantry Date: Mon, 4 Aug 2008 01:16:08 +0200 Subject: Avoid double slashes in URLs given to libdownload. If a Server specified in pacman.conf had a trailing slash, libalpm ended up building URLs with double slashes, and this broke libdownload with errors like the following one : error: failed retrieving file 'redland-1.0.8-1-i686.pkg.tar.gz' from 192.168.0.90 : Command okay So the public function alpm_db_set_server will make sure to remove the trailing slash of servers. For the private function _alpm_download_single_file, I only added a comment. Signed-off-by: Xavier Chantry Signed-off-by: Dan McGee --- lib/libalpm/dload.c | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/libalpm/dload.c') diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index ef12646e..c07040b5 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -365,6 +365,7 @@ static int download(const char *url, const char *localpath, * than mtimeold. * - if *mtimenew is non-NULL, it will be filled with the mtime of the remote * file. + * - servers must be a list of urls WITHOUT trailing slashes. * * RETURN: 0 for successful download * 1 if the mtimes are identical -- cgit v1.2.3-24-g4f1b