From 32413213cb3aa532f64bd19024f9694a22875e21 Mon Sep 17 00:00:00 2001 From: Allan McRae Date: Wed, 24 Dec 2014 11:59:55 +1000 Subject: apply_deltas: fix memory leak on error Signed-off-by: Allan McRae --- lib/libalpm/sync.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/libalpm/sync.c') diff --git a/lib/libalpm/sync.c b/lib/libalpm/sync.c index 36646759..e19655d9 100644 --- a/lib/libalpm/sync.c +++ b/lib/libalpm/sync.c @@ -736,11 +736,11 @@ static int apply_deltas(alpm_handle_t *handle) } else { /* len = cachedir len + from len + '/' + null */ len = strlen(cachedir) + strlen(d->from) + 2; - MALLOC(from, len, RET_ERR(handle, ALPM_ERR_MEMORY, 1)); + MALLOC(from, len, free(delta); RET_ERR(handle, ALPM_ERR_MEMORY, 1)); snprintf(from, len, "%s/%s", cachedir, d->from); } len = strlen(cachedir) + strlen(d->to) + 2; - MALLOC(to, len, free(from); RET_ERR(handle, ALPM_ERR_MEMORY, 1)); + MALLOC(to, len, free(delta); free(from); RET_ERR(handle, ALPM_ERR_MEMORY, 1)); snprintf(to, len, "%s/%s", cachedir, d->to); /* build the patch command */ -- cgit v1.2.3-24-g4f1b