From 8d26df5ee53d9fb4d2c7be97b7f099e3e8402186 Mon Sep 17 00:00:00 2001 From: Dave Reisner Date: Wed, 29 Feb 2012 21:55:44 -0500 Subject: makepkg: avoid use of eval in run_pacman Signed-off-by: Dave Reisner --- scripts/makepkg.sh.in | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'scripts/makepkg.sh.in') diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 14e2f6a0..1d906ba1 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -415,18 +415,18 @@ download_file() { run_pacman() { local cmd if [[ ! $1 = -@(T|Qq) ]]; then - printf -v cmd "%q " "$PACMAN" $PACMAN_OPTS "$@" + cmd=("$PACMAN" $PACMAN_OPTS "$@") else - printf -v cmd "%q " "$PACMAN" "$@" + cmd=("$PACMAN" "$@") fi if (( ! ASROOT )) && [[ ! $1 = -@(T|Qq) ]]; then if type -p sudo >/dev/null; then - cmd="sudo $cmd" + cmd=(sudo "${cmd[@]}") else - cmd="su root -c '$cmd'" + cmd=(su root -c "$(printf '%q ' "${cmd[@]}")") fi fi - eval "$cmd" + "${cmd[@]}" } check_deps() { -- cgit v1.2.3-24-g4f1b