From 82162859fa9bc528fedf284e5bf6618ae98f1a7d Mon Sep 17 00:00:00 2001 From: Tobias Oetiker Date: Thu, 22 Mar 2012 23:00:25 +0100 Subject: fork alert handlers, so that smokeping does not block --- lib/Smokeping.pm | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/Smokeping.pm b/lib/Smokeping.pm index bba6dca..f5743c0 100644 --- a/lib/Smokeping.pm +++ b/lib/Smokeping.pm @@ -1872,10 +1872,18 @@ sub check_alerts { next unless $addr; if ( $addr =~ /^\|(.+)/) { my $cmd = $1; - if ($edgetrigger) { - system $cmd,$_,$line,$loss,$rtt,$tree->{host}, ($what =~/raise/); - } else { - system $cmd,$_,$line,$loss,$rtt,$tree->{host}; + # fork them in case they + unless ($pid = fork) { + unless (fork) { + $SIG{CHLD} = 'DEFAULT'; + if ($edgetrigger) { + exec $cmd,$_,$line,$loss,$rtt,$tree->{host}, ($what =~/raise/); + } else { + exec $cmd,$_,$line,$loss,$rtt,$tree->{host}; + } + die "exec failed!"; + } + exit 0; } } elsif ( $addr =~ /^snpp:(.+)/ ) { -- cgit v1.2.3-24-g4f1b