diff options
| author | XScorpion2 <rcalt2vt@gmail.com> | 2019-05-01 20:36:50 +0200 |
|---|---|---|
| committer | MechMerlin <30334081+mechmerlin@users.noreply.github.com> | 2019-05-01 20:36:50 +0200 |
| commit | 3235c8527dd292d4a5e5e28302e118f3ef1a043e (patch) | |
| tree | dd1c013612ed0f4379653b0e7171d439bf140827 | |
| parent | 22ba36a4d86c06ce1b6049555525646eb16bb57a (diff) | |
| download | qmk_firmware-3235c8527dd292d4a5e5e28302e118f3ef1a043e.tar.gz qmk_firmware-3235c8527dd292d4a5e5e28302e118f3ef1a043e.tar.xz | |
Simple fix for selecting which tracked key press to work off of for simple reactive effects (#5745)
| -rw-r--r-- | quantum/rgb_matrix_animations/solid_reactive_anim.h | 3 | ||||
| -rw-r--r-- | quantum/rgb_matrix_animations/solid_reactive_simple_anim.h | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/quantum/rgb_matrix_animations/solid_reactive_anim.h b/quantum/rgb_matrix_animations/solid_reactive_anim.h index 836409dd6..82483653a 100644 --- a/quantum/rgb_matrix_animations/solid_reactive_anim.h +++ b/quantum/rgb_matrix_animations/solid_reactive_anim.h @@ -15,7 +15,8 @@ bool rgb_matrix_solid_reactive(effect_params_t* params) { for (uint8_t i = led_min; i < led_max; i++) { RGB_MATRIX_TEST_LED_FLAGS(); uint16_t tick = max_tick; - for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) { + // Reverse search to find most recent key hit + for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) { if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) { tick = g_last_hit_tracker.tick[j]; break; diff --git a/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h b/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h index d7bdb414e..9fc4d527a 100644 --- a/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h +++ b/quantum/rgb_matrix_animations/solid_reactive_simple_anim.h @@ -14,7 +14,8 @@ bool rgb_matrix_solid_reactive_simple(effect_params_t* params) { for (uint8_t i = led_min; i < led_max; i++) { RGB_MATRIX_TEST_LED_FLAGS(); uint16_t tick = max_tick; - for(uint8_t j = 0; j < g_last_hit_tracker.count; j++) { + // Reverse search to find most recent key hit + for (int8_t j = g_last_hit_tracker.count - 1; j >= 0; j--) { if (g_last_hit_tracker.index[j] == i && g_last_hit_tracker.tick[j] < tick) { tick = g_last_hit_tracker.tick[j]; break; |