From 800ec55dfca06b4630acf62cbb5f130c4031e4f1 Mon Sep 17 00:00:00 2001 From: Jack Humbert Date: Sat, 14 Oct 2017 11:32:19 -1000 Subject: Make arguments redo, subproject elimination (#1784) * redo make args to use colons, better folder structuring system [skip ci] * don't put spaces after statements - hard lessons in makefile development * fix-up some other rules.mk * give travis a chance * reset KEYMAPS variable * start converting keyboards to new system * try making all with travis * redo make args to use colons, better folder structuring system [skip ci] * don't put spaces after statements - hard lessons in makefile development * fix-up some other rules.mk * give travis a chance * reset KEYMAPS variable * start converting keyboards to new system * try making all with travis * start to update readmes and keyboards * look in keyboard directories for board.mk * update visualizer rules * fix up some other keyboards/keymaps * fix arm board ld includes * fix board rules * fix up remaining keyboards * reset layout variable * reset keyboard_layouts * fix remainging keymaps/boards * update readmes, docs * add note to makefile error * update readmes * remove planck keymap warnings * update references and docs * test out tarvis build stages * don't use stages for now * don't use stages for now --- keyboards/orthodox/config.h | 6 +----- keyboards/orthodox/keymaps/default/config.h | 2 +- keyboards/orthodox/keymaps/default/rules.mk | 3 --- keyboards/orthodox/keymaps/drashna/config.h | 2 +- keyboards/orthodox/keymaps/drashna/rules.mk | 6 +----- keyboards/orthodox/orthodox.h | 2 +- keyboards/orthodox/readme.md | 10 +++++----- keyboards/orthodox/rev1/config.h | 2 +- keyboards/orthodox/rev1/rev1.h | 2 +- keyboards/orthodox/rev1/rules.mk | 6 +----- keyboards/orthodox/rules.mk | 2 ++ 11 files changed, 15 insertions(+), 28 deletions(-) (limited to 'keyboards/orthodox') diff --git a/keyboards/orthodox/config.h b/keyboards/orthodox/config.h index b1a5b9cf9..821cd7e29 100644 --- a/keyboards/orthodox/config.h +++ b/keyboards/orthodox/config.h @@ -23,9 +23,5 @@ along with this program. If not, see . #define CONFIG_H #include "config_common.h" - -#ifdef SUBPROJECT_rev1 - #include "rev1/config.h" -#endif - + #endif diff --git a/keyboards/orthodox/keymaps/default/config.h b/keyboards/orthodox/keymaps/default/config.h index f24c6db29..c2892b5e0 100644 --- a/keyboards/orthodox/keymaps/default/config.h +++ b/keyboards/orthodox/keymaps/default/config.h @@ -22,7 +22,7 @@ along with this program. If not, see . #ifndef CONFIG_USER_H #define CONFIG_USER_H -#include "../../config.h" +#include "config_common.h" /* Use I2C or Serial, not both */ diff --git a/keyboards/orthodox/keymaps/default/rules.mk b/keyboards/orthodox/keymaps/default/rules.mk index 457a3d01d..e69de29bb 100644 --- a/keyboards/orthodox/keymaps/default/rules.mk +++ b/keyboards/orthodox/keymaps/default/rules.mk @@ -1,3 +0,0 @@ -ifndef QUANTUM_DIR - include ../../../../Makefile -endif diff --git a/keyboards/orthodox/keymaps/drashna/config.h b/keyboards/orthodox/keymaps/drashna/config.h index 7cbbf1025..bcd14a22d 100644 --- a/keyboards/orthodox/keymaps/drashna/config.h +++ b/keyboards/orthodox/keymaps/drashna/config.h @@ -22,7 +22,7 @@ along with this program. If not, see . #ifndef CONFIG_USER_H #define CONFIG_USER_H -#include "../../config.h" +#include "config_common.h" /* Use I2C or Serial, not both */ diff --git a/keyboards/orthodox/keymaps/drashna/rules.mk b/keyboards/orthodox/keymaps/drashna/rules.mk index e252a9044..2090afe9a 100644 --- a/keyboards/orthodox/keymaps/drashna/rules.mk +++ b/keyboards/orthodox/keymaps/drashna/rules.mk @@ -1,6 +1,2 @@ CONSOLE_ENABLE = yes -TAP_DANCE_ENABLE = yes - -ifndef QUANTUM_DIR - include ../../../../Makefile -endif +TAP_DANCE_ENABLE = yes \ No newline at end of file diff --git a/keyboards/orthodox/orthodox.h b/keyboards/orthodox/orthodox.h index b33356e5e..89707467a 100644 --- a/keyboards/orthodox/orthodox.h +++ b/keyboards/orthodox/orthodox.h @@ -1,7 +1,7 @@ #ifndef ORTHODOX_H #define ORTHODOX_H -#ifdef SUBPROJECT_rev1 +#ifdef KEYBOARD_orthodox_rev1 #include "rev1.h" #endif diff --git a/keyboards/orthodox/readme.md b/keyboards/orthodox/readme.md index e1fbf94ba..fb591b007 100644 --- a/keyboards/orthodox/readme.md +++ b/keyboards/orthodox/readme.md @@ -34,10 +34,10 @@ For further reading on build- and flashing-procedures for split ortholinear skel ## First Time Setup -Download or clone the whole firmware and navigate to the keyboards/orthodox directory. Once your dev env is setup, you'll be able to generate the default .hex using: +Download or clone the whole firmware and navigate to the root directory. Once your dev env is setup, you'll be able to generate the default .hex using: ``` -$ make rev1-default +$ make orthodox/rev1:default ``` You will see a lot of output and if everything worked correctly you will see the built hex files in your *root qmk_firmware directory* two levels up: @@ -50,7 +50,7 @@ If you would like to use one of the alternative keymaps, or create your own, cop ``` -$ make rev1-YOUR_KEYMAP_NAME +$ make orthodox/rev1:YOUR_KEYMAP_NAME ``` If everything worked correctly you will see a file: @@ -96,8 +96,8 @@ the two halves, i.e. if your split keyboard has 3 rows in each half, then Flashing ------- -From the `orthodox` directory run `make SUBPROJECT-KEYMAP-avrdude` for automatic serial port resolution and flashing. -Example: `make rev2-default-avrdude` +From the root directory run `make PROJECT:KEYMAP:avrdude` for automatic serial port resolution and flashing. +Example: `make orthodox/rev2:default:avrdude` Choosing which board to plug the USB cable into (choosing Master) diff --git a/keyboards/orthodox/rev1/config.h b/keyboards/orthodox/rev1/config.h index 05f043b4c..26715f409 100644 --- a/keyboards/orthodox/rev1/config.h +++ b/keyboards/orthodox/rev1/config.h @@ -22,7 +22,7 @@ along with this program. If not, see . #ifndef REV1_CONFIG_H #define REV1_CONFIG_H -#include "../config.h" +#include "config_common.h" /* USB Device descriptor parameter */ #define VENDOR_ID 0xFEED diff --git a/keyboards/orthodox/rev1/rev1.h b/keyboards/orthodox/rev1/rev1.h index 06282b234..ceaaaed28 100644 --- a/keyboards/orthodox/rev1/rev1.h +++ b/keyboards/orthodox/rev1/rev1.h @@ -22,7 +22,7 @@ along with this program. If not, see . #ifndef REV1_H #define REV1_H -#include "../orthodox.h" +#include "orthodox.h" //void promicro_bootloader_jmp(bool program); #include "quantum.h" diff --git a/keyboards/orthodox/rev1/rules.mk b/keyboards/orthodox/rev1/rules.mk index a0825b4ef..f84561674 100644 --- a/keyboards/orthodox/rev1/rules.mk +++ b/keyboards/orthodox/rev1/rules.mk @@ -1,5 +1 @@ -BACKLIGHT_ENABLE = no - -ifndef QUANTUM_DIR - include ../../../Makefile -endif \ No newline at end of file +BACKLIGHT_ENABLE = no \ No newline at end of file diff --git a/keyboards/orthodox/rules.mk b/keyboards/orthodox/rules.mk index 3f40ff2f8..48d6551bc 100644 --- a/keyboards/orthodox/rules.mk +++ b/keyboards/orthodox/rules.mk @@ -73,3 +73,5 @@ USE_I2C = yes SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend CUSTOM_MATRIX = yes + +DEFAULT_FOLDER = orthodox/rev1 -- cgit v1.2.3-24-g4f1b