Patch for bug 252810: p1, critical not displayed in red when groups are

used for bug. Roundabout patch that adds a padlock icon next to the bug
ID to bug listings, and does even/odd striping of the buglist. r,a=myk.

3 files changed, 51 insertions, 19 deletions

diff --git a/css/buglist.css b/css/buglist.css
index ab595d85e..6051b95d9 100644
--- a/css/buglist.css
+++ b/css/buglist.css
@@ -26,13 +26,27 @@
 .bz_critical { color: red; }
 .bz_enhancement { color: #888; background-color: white; }
 
-/* Style secure bugs if the installation is not using bug groups.
- * Installations that *are* using bug groups are likely to be using
- * them for almost all bugs, in which case special styling is not
- * informative and generally a nuisance.
- */
-.bz_secure { color: black; background-color: lightgrey; }
-
 /* Align columns in the "change multiple bugs" form to the right. */
 table#form tr th { text-align: right; }
 
+table.bz_buglist td, table.bz_buglist th { 
+    padding-left: 20px;
+}
+
+/* For styling rows; by default striped white and gray */
+tr.bz_odd {
+    background-color: #e6e6e6;
+}
+
+tr.bz_even {
+}
+
+/* we use a first-child class and not the pseudo-class because IE
+ * doesn't support it :-( */
+tr.bz_secure td.first-child { 
+  background-image: url("../images/padlock.png");
+  background-position: center left;
+  background-repeat: no-repeat;
+  background-color: inherit;
+}
+
diff --git a/skins/standard/buglist.css b/skins/standard/buglist.css
index ab595d85e..6051b95d9 100644
--- a/skins/standard/buglist.css
+++ b/skins/standard/buglist.css
@@ -26,13 +26,27 @@
 .bz_critical { color: red; }
 .bz_enhancement { color: #888; background-color: white; }
 
-/* Style secure bugs if the installation is not using bug groups.
- * Installations that *are* using bug groups are likely to be using
- * them for almost all bugs, in which case special styling is not
- * informative and generally a nuisance.
- */
-.bz_secure { color: black; background-color: lightgrey; }
-
 /* Align columns in the "change multiple bugs" form to the right. */
 table#form tr th { text-align: right; }
 
+table.bz_buglist td, table.bz_buglist th { 
+    padding-left: 20px;
+}
+
+/* For styling rows; by default striped white and gray */
+tr.bz_odd {
+    background-color: #e6e6e6;
+}
+
+tr.bz_even {
+}
+
+/* we use a first-child class and not the pseudo-class because IE
+ * doesn't support it :-( */
+tr.bz_secure td.first-child { 
+  background-image: url("../images/padlock.png");
+  background-position: center left;
+  background-repeat: no-repeat;
+  background-color: inherit;
+}
+
diff --git a/template/en/default/list/table.html.tmpl b/template/en/default/list/table.html.tmpl
index fa2ca7766..5a2cf8418 100644
--- a/template/en/default/list/table.html.tmpl
+++ b/template/en/default/list/table.html.tmpl
@@ -140,25 +140,29 @@
 [%############################################################################%]
 
 [% FOREACH bug = bugs %]
-  [% FLUSH IF loop.count() % 10 == 1 %]
+  [% count = loop.count() %]
+  [% FLUSH IF count % 10 == 1 %]
 
   [%# At the beginning of every hundred bugs in the list, start a new table. %]
-  [% IF loop.count() % 100 == 1 %]
+  [% IF count % 100 == 1 %]
     [% tableheader %]
   [% END %]
 
   <tr class="bz_[% bug.bug_severity FILTER css_class_quote %]
              bz_[% bug.priority FILTER css_class_quote %]
              bz_[% bug.bug_status FILTER css_class_quote %]
-             bz_[% bug.resolution FILTER css_class_quote %]
-             [%+ "bz_secure" IF bug.isingroups %]">
+             [%+ "bz_$bug.resolution" FILTER css_class_quote IF bug.resolution %]
+             [%+ "bz_secure" IF bug.isingroups %]
+             [%+ count % 2 == 1 ? "bz_odd" : "bz_even" %]
+             ">
+             
 
     [% IF dotweak %]
     <td>
       <input type="checkbox" name="id_[% bug.bug_id %]">
     </td>
     [% END %]
-    <td>
+    <td class="first-child">
       <a href="show_bug.cgi?id=[% bug.bug_id %]">[% bug.bug_id %]</a>
     </td>