summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Lawrence <dlawrence@mozilla.com>2013-11-13 17:45:13 +0100
committerDave Lawrence <dlawrence@mozilla.com>2013-11-13 17:45:13 +0100
commitd52ce71f7101596e05771f02f5cca7ce5df059d0 (patch)
tree8bcb49efe2d5057d6e30a5f2ff4aed75a3e1299f
parentca8cbc67699faaf38038578ce7aee9439a245aac (diff)
downloadbugzilla-d52ce71f7101596e05771f02f5cca7ce5df059d0.tar.gz
bugzilla-d52ce71f7101596e05771f02f5cca7ce5df059d0.tar.xz
Bug 843298 - Project Kickoff Form: require explicit public/private choice
r=dkl
-rw-r--r--extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl18
-rw-r--r--extensions/MozProjectReview/web/js/moz_project_review.js10
2 files changed, 26 insertions, 2 deletions
diff --git a/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl b/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
index f4fc6ea7a..433d61263 100644
--- a/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
+++ b/extensions/MozProjectReview/template/en/default/bug/create/create-moz-project-review.html.tmpl
@@ -26,12 +26,11 @@
<span class="required_explanation">Required Field</span>)
</p>
-<form method="post" action="post_bug.cgi" id="incidentForm" enctype="multipart/form-data"
+<form method="post" action="post_bug.cgi" id="mozProjectForm" enctype="multipart/form-data"
onSubmit="return MPR.validateAndSubmit();">
<input type="hidden" id="product" name="product" value="mozilla.org">
<input type="hidden" id="component" name="component" value="Project Review">
<input type="hidden" id="rep_platform" name="rep_platform" value="All">
- <input type="hidden" id="groups" name="groups" value="mozilla-corporation-confidential">
<input type="hidden" id="op_sys" name="op_sys" value="All">
<input type="hidden" id="priority" name="priority" value="--">
<input type="hidden" id="version" name="version" value="other">
@@ -51,6 +50,21 @@
</span>
</div>
+ <div id="visibility_row" class="field_row">
+ <span class="field_label required">Project Visibility:</span>
+ <span class="field_data">
+ <div class="field_description">
+ Whether project itself is a secret or not (dependent [% terms.bugs %],
+ e.g. Finance and Sec Review, will be made secure whatever you choose).
+ </div>
+ <select name="visibility" id="visibility">
+ <option value="">Select One</option>
+ <option value="public">Public</option>
+ <option value="private">MoCo Confidentional</option>
+ </select>
+ </span>
+ </div>
+
<div id="tracking_id_row" class="field_row">
<span class="field_label">Tracking [% terms.Bug %] ID:</span>
<span class="field_data">
diff --git a/extensions/MozProjectReview/web/js/moz_project_review.js b/extensions/MozProjectReview/web/js/moz_project_review.js
index 5ea1d1a0e..2dfbeb87f 100644
--- a/extensions/MozProjectReview/web/js/moz_project_review.js
+++ b/extensions/MozProjectReview/web/js/moz_project_review.js
@@ -13,6 +13,7 @@ var MPR = {
required_fields: {
"initial_questions": {
"short_desc": "Please enter a value for project or feature name in the initial questions section",
+ "visibility": "Please select a value for project visibility in the initial questions section",
"cc": "Please enter a value for points of contact in the initial questions section",
"key_initiative": "Please select a value for key initiative in the initial questions section",
"release_date": "Please enter a value for release date in the initial questions section",
@@ -242,6 +243,15 @@ var MPR = {
return false;
}
+ var visibility = MPR.fieldValue('visibility');
+ if (visibility == 'private') {
+ var groups = document.createElement('input');
+ groups.type = 'hidden';
+ groups.name = 'groups';
+ groups.value = 'mozilla-corporation-confidential';
+ Dom.get('mozProjectForm').appendChild(groups);
+ }
+
return true;
},