diff options
author | lpsolit%gmail.com <> | 2009-08-09 21:51:43 +0200 |
---|---|---|
committer | lpsolit%gmail.com <> | 2009-08-09 21:51:43 +0200 |
commit | dd6720f4af864e29e49d26befe1ec1b04a92a71c (patch) | |
tree | e990543b337c76dabc6253fb5cbbf93b8e1f1130 | |
parent | caab33ef1a7e8da98fa1681d2e80b5c6f4a19959 (diff) | |
download | bugzilla-dd6720f4af864e29e49d26befe1ec1b04a92a71c.tar.gz bugzilla-dd6720f4af864e29e49d26befe1ec1b04a92a71c.tar.xz |
Bug 471620: USER_PASSWORD_MAX_LENGTH is no longer needed - Patch by Frédéric Buclin <LpSolit@gmail.com> r=dkl a=LpSolit
-rw-r--r-- | Bugzilla/Constants.pm | 4 | ||||
-rw-r--r-- | Bugzilla/User.pm | 2 | ||||
-rw-r--r-- | Bugzilla/WebService/Constants.pm | 1 | ||||
-rw-r--r-- | template/en/default/global/user-error.html.tmpl | 5 |
4 files changed, 1 insertions, 11 deletions
diff --git a/Bugzilla/Constants.pm b/Bugzilla/Constants.pm index 294d03491..ef3853788 100644 --- a/Bugzilla/Constants.pm +++ b/Bugzilla/Constants.pm @@ -57,7 +57,6 @@ use File::Basename; AUTH_NO_SUCH_USER USER_PASSWORD_MIN_LENGTH - USER_PASSWORD_MAX_LENGTH LOGIN_OPTIONAL LOGIN_NORMAL @@ -226,9 +225,8 @@ use constant AUTH_LOGINFAILED => 3; use constant AUTH_DISABLED => 4; use constant AUTH_NO_SUCH_USER => 5; -# The minimum and maximum lengths a password must have. +# The minimum length a password must have. use constant USER_PASSWORD_MIN_LENGTH => 3; -use constant USER_PASSWORD_MAX_LENGTH => 16; use constant LOGIN_OPTIONAL => 0; use constant LOGIN_NORMAL => 1; diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 0eb47b8b3..ff486684b 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -1706,8 +1706,6 @@ sub validate_password { if (length($password) < USER_PASSWORD_MIN_LENGTH) { ThrowUserError('password_too_short'); - } elsif (length($password) > USER_PASSWORD_MAX_LENGTH) { - ThrowUserError('password_too_long'); } elsif ((defined $matchpassword) && ($password ne $matchpassword)) { ThrowUserError('passwords_dont_match'); } diff --git a/Bugzilla/WebService/Constants.pm b/Bugzilla/WebService/Constants.pm index 260ae9478..8e7465a5a 100644 --- a/Bugzilla/WebService/Constants.pm +++ b/Bugzilla/WebService/Constants.pm @@ -103,7 +103,6 @@ use constant WS_ERROR_CODE => { account_creation_disabled => 501, account_creation_restricted => 501, password_too_short => 502, - password_too_long => 503, invalid_username => 504, # This is from strict_isolation, but it also basically means # "invalid user." diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index a30f29706..58cf4e01d 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -1276,11 +1276,6 @@ [% title = "Passwords Don't Match" %] The two passwords you entered did not match. - [% ELSIF error == "password_too_long" %] - [% title = "Password Too Long" %] - The password must be no more than - [%+ constants.USER_PASSWORD_MAX_LENGTH FILTER html %] characters long. - [% ELSIF error == "password_too_short" %] [% title = "Password Too Short" %] The password must be at least |