summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Tyson <mtyson@redhat.com>2013-02-17 02:19:08 +0100
committerFrédéric Buclin <LpSolit@gmail.com>2013-02-17 02:19:08 +0100
commite3d3e70335676218800c30a3761c32f7c1887e39 (patch)
treeda7cdad905574ccd53abaf85f69120b35dfabcf7
parent8cd4a05a712a3513ae37ced423b7cabdf1730b30 (diff)
downloadbugzilla-e3d3e70335676218800c30a3761c32f7c1887e39.tar.gz
bugzilla-e3d3e70335676218800c30a3761c32f7c1887e39.tar.xz
Bug 839950: Cannot search by Change History on multi-select fields
r/a=LpSolit
-rw-r--r--Bugzilla/Bug.pm8
1 files changed, 6 insertions, 2 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 9610acb7b..cad024bbd 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3650,9 +3650,13 @@ sub bug_alias_to_id {
# Subroutines
#####################################################################
-# Represents which fields from the bugs table are handled by process_bug.cgi.
+# Returns a list of currently active and editable bug fields,
+# including multi-select fields.
sub editable_bug_fields {
my @fields = Bugzilla->dbh->bz_table_columns('bugs');
+ # Add multi-select fields
+ push(@fields, map { $_->name } @{Bugzilla->fields({obsolete => 0,
+ type => FIELD_TYPE_MULTI_SELECT})});
# Obsolete custom fields are not editable.
my @obsolete_fields = @{ Bugzilla->fields({obsolete => 1, custom => 1}) };
@obsolete_fields = map { $_->name } @obsolete_fields;
@@ -3660,7 +3664,7 @@ sub editable_bug_fields {
"lastdiffed", @obsolete_fields)
{
my $location = firstidx { $_ eq $remove } @fields;
- # Custom multi-select fields are not stored in the bugs table.
+ # Ensure field exists before attempting to remove it.
splice(@fields, $location, 1) if ($location > -1);
}
# Sorted because the old @::log_columns variable, which this replaces,