diff options
| author | jocuri%softhome.net <> | 2004-07-03 09:26:28 +0200 |
|---|---|---|
| committer | jocuri%softhome.net <> | 2004-07-03 09:26:28 +0200 |
| commit | 00cc8677e25a98e81d70757cc02991e63ee3b975 (patch) | |
| tree | bb065f42db71af22477394a6e1648794096df3c9 | |
| parent | 7600babc226dfaad905fb78a978715639b75e48f (diff) | |
| download | bugzilla-00cc8677e25a98e81d70757cc02991e63ee3b975.tar.gz bugzilla-00cc8677e25a98e81d70757cc02991e63ee3b975.tar.xz | |
Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.
| -rwxr-xr-x | Bugzilla/Bug.pm | 4 | ||||
| -rwxr-xr-x | buglist.cgi | 4 | ||||
| -rwxr-xr-x | editgroups.cgi | 2 | ||||
| -rwxr-xr-x | request.cgi | 4 |
4 files changed, 7 insertions, 7 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index bef512e0f..91cd0d8c8 100755 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -342,11 +342,11 @@ sub groups { " LEFT JOIN user_group_map" . " ON user_group_map.group_id = groups.id" . " AND user_id = $::userid" . - " AND NOT isbless" . + " AND isbless = 0" . " LEFT JOIN group_control_map" . " ON group_control_map.group_id = groups.id" . " AND group_control_map.product_id = " . $self->{'product_id'} . - " WHERE isbuggroup"); + " WHERE isbuggroup = 1"); while (&::MoreSQLData()) { my ($groupid, $name, $description, $ison, $ingroup, $isactive, diff --git a/buglist.cgi b/buglist.cgi index 98b7ff116..2607628d0 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -246,9 +246,9 @@ sub GetGroupsByUserId { SendSQL(" SELECT DISTINCT groups.id, name, description, isactive FROM groups, user_group_map - WHERE user_id = $userid AND NOT isbless + WHERE user_id = $userid AND isbless = 0 AND user_group_map.group_id = groups.id - AND isbuggroup + AND isbuggroup = 1 ORDER BY description "); my @groups; diff --git a/editgroups.cgi b/editgroups.cgi index a0af0be12..4390b5d44 100755 --- a/editgroups.cgi +++ b/editgroups.cgi @@ -274,7 +274,7 @@ if ($action eq 'changeform') { " LEFT JOIN group_group_map as B" . " ON B.member_id = groups.id" . " AND B.grantor_id = $group_id" . - " AND B.isbless" . + " AND B.isbless = 1" . " WHERE groups.id != $group_id ORDER by name"); while (MoreSQLData()) { diff --git a/request.cgi b/request.cgi index 43be69856..e330c2c83 100755 --- a/request.cgi +++ b/request.cgi @@ -81,8 +81,8 @@ sub queue { # should not have access. " COUNT(DISTINCT ugmap.group_id) AS cntuseringroups, COUNT(DISTINCT bgmap.group_id) AS cntbugingroups, - ((COUNT(DISTINCT ccmap.who) AND cclist_accessible) - OR ((bugs.reporter = $::userid) AND bugs.reporter_accessible) + ((COUNT(DISTINCT ccmap.who) AND cclist_accessible = 1) + OR ((bugs.reporter = $::userid) AND bugs.reporter_accessible = 1) OR bugs.assigned_to = $::userid ) AS canseeanyway " . # Use the flags and flagtypes tables for information about the flags, |