summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKohei Yoshino <kohei.yoshino@gmail.com>2018-07-19 04:44:38 +0200
committerDylan William Hardison <dylan@hardison.net>2018-07-19 04:44:38 +0200
commit08e31d692fec488ef88a18040d28ebbfc9c6b443 (patch)
tree001c92f313545b79e101d6f02924c6d4c9945f1f
parent535a1fd09e4b150e31165e2e79af42c2e5f2bda5 (diff)
downloadbugzilla-08e31d692fec488ef88a18040d28ebbfc9c6b443.tar.gz
bugzilla-08e31d692fec488ef88a18040d28ebbfc9c6b443.tar.xz
Bug 1136271 - Make user profile page visible to anyone for easier sharing
-rw-r--r--extensions/BMO/template/en/default/pages/group_members.html.tmpl2
-rw-r--r--extensions/BMO/web/js/edituser_menu.js2
-rw-r--r--extensions/Gravatar/template/en/default/hook/bug/comments-user-image.html.tmpl6
-rw-r--r--extensions/UserProfile/template/en/default/hook/account/prefs/account-start.html.tmpl2
-rw-r--r--template/en/default/global/header.html.tmpl4
5 files changed, 6 insertions, 10 deletions
diff --git a/extensions/BMO/template/en/default/pages/group_members.html.tmpl b/extensions/BMO/template/en/default/pages/group_members.html.tmpl
index ec2cb2e46..1c593c07e 100644
--- a/extensions/BMO/template/en/default/pages/group_members.html.tmpl
+++ b/extensions/BMO/template/en/default/pages/group_members.html.tmpl
@@ -82,7 +82,7 @@
<a href="editusers.cgi?action=edit&amp;userid=[% member.id FILTER none %]"
target="_blank">
[% ELSE %]
- <a href="user_profile?login=[% member.login FILTER uri %]"
+ <a href="user_profile?user_id=[% member.id FILTER none %]"
target="_blank">
[% END %]
<span [% 'class="bz_inactive"' UNLESS member.is_enabled %]>
diff --git a/extensions/BMO/web/js/edituser_menu.js b/extensions/BMO/web/js/edituser_menu.js
index 7008a2b84..a300f5c24 100644
--- a/extensions/BMO/web/js/edituser_menu.js
+++ b/extensions/BMO/web/js/edituser_menu.js
@@ -10,7 +10,7 @@ function show_usermenu(id, email, show_edit) {
{
name: "Profile",
callback: function () {
- var href = "user_profile?login=" + encodeURIComponent(email);
+ var href = "user_profile?user_id=" + id;
window.open(href, "_blank");
}
},
diff --git a/extensions/Gravatar/template/en/default/hook/bug/comments-user-image.html.tmpl b/extensions/Gravatar/template/en/default/hook/bug/comments-user-image.html.tmpl
index 3788a8452..361c02d2b 100644
--- a/extensions/Gravatar/template/en/default/hook/bug/comments-user-image.html.tmpl
+++ b/extensions/Gravatar/template/en/default/hook/bug/comments-user-image.html.tmpl
@@ -8,11 +8,7 @@
[% IF user.settings.show_gravatars.value == 'On' %]
[% IF who.last_activity_ts %]
- [% IF user.id %]
- <a href="user_profile?login=[% who.login FILTER uri %]">
- [% ELSE %]
- <a href="user_profile?user_id=[% who.id FILTER uri %]">
- [% END %]
+ <a href="user_profile?user_id=[% who.id FILTER none %]">
[% END %]
<img alt="User image" align="middle" src="[% who.gravatar FILTER none %]" width="32" height="32" border="0">
[% "</a>" IF who.last_activity_ts %]
diff --git a/extensions/UserProfile/template/en/default/hook/account/prefs/account-start.html.tmpl b/extensions/UserProfile/template/en/default/hook/account/prefs/account-start.html.tmpl
index f2e3aad01..b3a2fc5ea 100644
--- a/extensions/UserProfile/template/en/default/hook/account/prefs/account-start.html.tmpl
+++ b/extensions/UserProfile/template/en/default/hook/account/prefs/account-start.html.tmpl
@@ -6,6 +6,6 @@
# defined by the Mozilla Public License, v. 2.0.
#%]
-<a href="user_profile?login=[% user.login FILTER uri %]">
+<a href="user_profile?user_id=[% user.id FILTER none %]">
[% terms.Bugzilla %] User Profile
</a><br><hr>
diff --git a/template/en/default/global/header.html.tmpl b/template/en/default/global/header.html.tmpl
index a87b2015e..6a19eaf39 100644
--- a/template/en/default/global/header.html.tmpl
+++ b/template/en/default/global/header.html.tmpl
@@ -326,14 +326,14 @@
</button>
<ul class="dropdown-content left" id="header-account-menu" role="menu" style="display:none;">
<li role="presentation">
- <div href="user_profile" class="account-label">
+ <div class="account-label">
<div class="name">[% user.name FILTER html %]</div>
<div class="email">[% user.login FILTER html %]</div>
</div>
</li>
<li role="separator"></li>
<li role="presentation">
- <a href="user_profile" role="menuitem" tabindex="-1">My Profile</a>
+ <a href="user_profile?user_id=[% user.id FILTER none %]" role="menuitem" tabindex="-1">My Profile</a>
</li>
<li role="presentation">
<a href="page.cgi?id=user_activity.html&amp;action=run&amp;who=[% user.login FILTER uri %]" role="menuitem"