diff options
| author | Frédéric Buclin <LpSolit@gmail.com> | 2012-09-01 23:43:00 +0200 |
|---|---|---|
| committer | Frédéric Buclin <LpSolit@gmail.com> | 2012-09-01 23:43:00 +0200 |
| commit | 1001cbba7b16ccc4611bbee0474264bb551d1ea5 (patch) | |
| tree | 9596c12f8ed8730e864acdfc10ddd08b0796f8ef | |
| parent | 88157fb0e84c374031020e0bd4ca82bb450bb146 (diff) | |
| download | bugzilla-1001cbba7b16ccc4611bbee0474264bb551d1ea5.tar.gz bugzilla-1001cbba7b16ccc4611bbee0474264bb551d1ea5.tar.xz | |
Bug 787529: Use |use 5.10.1| everywhere
r=wicked a=LpSolit
195 files changed, 400 insertions, 150 deletions
diff --git a/Bugzilla.pm b/Bugzilla.pm index ccd384067..f956f5a0e 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -7,6 +7,7 @@ package Bugzilla; +use 5.10.1; use strict; # We want any compile errors to get to the browser, if possible. diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index d6c7e3924..1c524c24b 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Attachment; +use 5.10.1; +use strict; + =head1 NAME Bugzilla::Attachment - Bugzilla attachment class. diff --git a/Bugzilla/Attachment/PatchReader.pm b/Bugzilla/Attachment/PatchReader.pm index e9cb189ef..4583dbd51 100644 --- a/Bugzilla/Attachment/PatchReader.pm +++ b/Bugzilla/Attachment/PatchReader.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Attachment::PatchReader; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::Attachment; use Bugzilla::Util; diff --git a/Bugzilla/Auth.pm b/Bugzilla/Auth.pm index 477dbffaa..412edd5a1 100644 --- a/Bugzilla/Auth.pm +++ b/Bugzilla/Auth.pm @@ -7,6 +7,7 @@ package Bugzilla::Auth; +use 5.10.1; use strict; use fields qw( _info_getter diff --git a/Bugzilla/Auth/Login.pm b/Bugzilla/Auth/Login.pm index 290cb42ff..33d63a425 100644 --- a/Bugzilla/Auth/Login.pm +++ b/Bugzilla/Auth/Login.pm @@ -7,6 +7,7 @@ package Bugzilla::Auth::Login; +use 5.10.1; use strict; use fields qw(); diff --git a/Bugzilla/Auth/Login/CGI.pm b/Bugzilla/Auth/Login/CGI.pm index 47ec556a7..a4fb3aea2 100644 --- a/Bugzilla/Auth/Login/CGI.pm +++ b/Bugzilla/Auth/Login/CGI.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::CGI; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use constant user_can_create_account => 1; diff --git a/Bugzilla/Auth/Login/Cookie.pm b/Bugzilla/Auth/Login/Cookie.pm index 5d4c8279c..1f6f83f5e 100644 --- a/Bugzilla/Auth/Login/Cookie.pm +++ b/Bugzilla/Auth/Login/Cookie.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::Cookie; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Login/Env.pm b/Bugzilla/Auth/Login/Env.pm index 393ac600d..9b24c0edc 100644 --- a/Bugzilla/Auth/Login/Env.pm +++ b/Bugzilla/Auth/Login/Env.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::Env; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Login/Stack.pm b/Bugzilla/Auth/Login/Stack.pm index 17a5855b6..ad5598576 100644 --- a/Bugzilla/Auth/Login/Stack.pm +++ b/Bugzilla/Auth/Login/Stack.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Login::Stack; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Login); use fields qw( _stack diff --git a/Bugzilla/Auth/Persist/Cookie.pm b/Bugzilla/Auth/Persist/Cookie.pm index ec212088d..15a2d490e 100644 --- a/Bugzilla/Auth/Persist/Cookie.pm +++ b/Bugzilla/Auth/Persist/Cookie.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Persist::Cookie; + +use 5.10.1; use strict; use fields qw(); diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm index ae256dd8c..de8b4030d 100644 --- a/Bugzilla/Auth/Verify.pm +++ b/Bugzilla/Auth/Verify.pm @@ -7,6 +7,7 @@ package Bugzilla::Auth::Verify; +use 5.10.1; use strict; use fields qw(); diff --git a/Bugzilla/Auth/Verify/DB.pm b/Bugzilla/Auth/Verify/DB.pm index 6ca04f259..dc074b20a 100644 --- a/Bugzilla/Auth/Verify/DB.pm +++ b/Bugzilla/Auth/Verify/DB.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::DB; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Verify/LDAP.pm b/Bugzilla/Auth/Verify/LDAP.pm index 5704c5848..63e05ed45 100644 --- a/Bugzilla/Auth/Verify/LDAP.pm +++ b/Bugzilla/Auth/Verify/LDAP.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::LDAP; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use fields qw( ldap diff --git a/Bugzilla/Auth/Verify/RADIUS.pm b/Bugzilla/Auth/Verify/RADIUS.pm index d6c4db8e8..9fecec77e 100644 --- a/Bugzilla/Auth/Verify/RADIUS.pm +++ b/Bugzilla/Auth/Verify/RADIUS.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::RADIUS; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use Bugzilla::Constants; diff --git a/Bugzilla/Auth/Verify/Stack.pm b/Bugzilla/Auth/Verify/Stack.pm index 0930d57ed..52c449e22 100644 --- a/Bugzilla/Auth/Verify/Stack.pm +++ b/Bugzilla/Auth/Verify/Stack.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Auth::Verify::Stack; + +use 5.10.1; use strict; + use base qw(Bugzilla::Auth::Verify); use fields qw( _stack diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm index 2e9ed52e0..f47ed81c9 100644 --- a/Bugzilla/Bug.pm +++ b/Bugzilla/Bug.pm @@ -7,6 +7,7 @@ package Bugzilla::Bug; +use 5.10.1; use strict; use Bugzilla::Attachment; diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm index 764b223db..2c1ab5885 100644 --- a/Bugzilla/BugMail.pm +++ b/Bugzilla/BugMail.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::BugMail; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::User; use Bugzilla::Constants; diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm index 8689e8a35..ec6675e90 100644 --- a/Bugzilla/BugUrl.pm +++ b/Bugzilla/BugUrl.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl; + +use 5.10.1; use strict; + use base qw(Bugzilla::Object); use Bugzilla::Util; diff --git a/Bugzilla/BugUrl/Bugzilla.pm b/Bugzilla/BugUrl/Bugzilla.pm index 4db37eb7f..8e2f37226 100644 --- a/Bugzilla/BugUrl/Bugzilla.pm +++ b/Bugzilla/BugUrl/Bugzilla.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Bugzilla; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); use Bugzilla::Error; diff --git a/Bugzilla/BugUrl/Bugzilla/Local.pm b/Bugzilla/BugUrl/Bugzilla/Local.pm index 9631716ae..360d5dd97 100644 --- a/Bugzilla/BugUrl/Bugzilla/Local.pm +++ b/Bugzilla/BugUrl/Bugzilla/Local.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Bugzilla::Local; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl::Bugzilla); use Bugzilla::Error; diff --git a/Bugzilla/BugUrl/Debian.pm b/Bugzilla/BugUrl/Debian.pm index 78397bdd9..f791a437e 100644 --- a/Bugzilla/BugUrl/Debian.pm +++ b/Bugzilla/BugUrl/Debian.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Debian; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/GitHub.pm b/Bugzilla/BugUrl/GitHub.pm index 63be65bed..1dc325c80 100644 --- a/Bugzilla/BugUrl/GitHub.pm +++ b/Bugzilla/BugUrl/GitHub.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::GitHub; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/Google.pm b/Bugzilla/BugUrl/Google.pm index 8b8638c7a..809c92cca 100644 --- a/Bugzilla/BugUrl/Google.pm +++ b/Bugzilla/BugUrl/Google.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Google; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/JIRA.pm b/Bugzilla/BugUrl/JIRA.pm index f5f7ee5fa..d9614c4bd 100644 --- a/Bugzilla/BugUrl/JIRA.pm +++ b/Bugzilla/BugUrl/JIRA.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::JIRA; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/Launchpad.pm b/Bugzilla/BugUrl/Launchpad.pm index 87fb71a5d..f858f2895 100644 --- a/Bugzilla/BugUrl/Launchpad.pm +++ b/Bugzilla/BugUrl/Launchpad.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Launchpad; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/MantisBT.pm b/Bugzilla/BugUrl/MantisBT.pm index 3d49ede69..d774eca10 100644 --- a/Bugzilla/BugUrl/MantisBT.pm +++ b/Bugzilla/BugUrl/MantisBT.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::MantisBT; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/SourceForge.pm b/Bugzilla/BugUrl/SourceForge.pm index 11cdd0ff1..ee9a3e7ca 100644 --- a/Bugzilla/BugUrl/SourceForge.pm +++ b/Bugzilla/BugUrl/SourceForge.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::SourceForge; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/BugUrl/Trac.pm b/Bugzilla/BugUrl/Trac.pm index 8f6e9cd0e..ddad281fe 100644 --- a/Bugzilla/BugUrl/Trac.pm +++ b/Bugzilla/BugUrl/Trac.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::BugUrl::Trac; + +use 5.10.1; use strict; + use base qw(Bugzilla::BugUrl); ############################### diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index a68195f22..99851c21d 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::CGI; + +use 5.10.1; use strict; + use base qw(CGI); use Bugzilla::Constants; diff --git a/Bugzilla/Chart.pm b/Bugzilla/Chart.pm index 0a655769f..d157457c2 100644 --- a/Bugzilla/Chart.pm +++ b/Bugzilla/Chart.pm @@ -5,8 +5,6 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - # This module represents a chart. # # Note that it is perfectly legal for the 'lines' member variable of this @@ -15,6 +13,9 @@ use strict; # the same points. package Bugzilla::Chart; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::Util; use Bugzilla::Series; diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm index 2b35a8839..67ba8b46f 100644 --- a/Bugzilla/Classification.pm +++ b/Bugzilla/Classification.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Classification; +use 5.10.1; +use strict; + use Bugzilla::Constants; use Bugzilla::Field; use Bugzilla::Util; diff --git a/Bugzilla/Comment.pm b/Bugzilla/Comment.pm index 549753d2b..7cf924893 100644 --- a/Bugzilla/Comment.pm +++ b/Bugzilla/Comment.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Comment; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Attachment; diff --git a/Bugzilla/Component.pm b/Bugzilla/Component.pm index f18963946..b8321cbf9 100644 --- a/Bugzilla/Component.pm +++ b/Bugzilla/Component.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Component; + +use 5.10.1; use strict; + use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm index 150996e05..f422de227 100644 --- a/Bugzilla/Config.pm +++ b/Bugzilla/Config.pm @@ -7,6 +7,7 @@ package Bugzilla::Config; +use 5.10.1; use strict; use base qw(Exporter); diff --git a/Bugzilla/Config/Admin.pm b/Bugzilla/Config/Admin.pm index 7be3e54d1..811f7029e 100644 --- a/Bugzilla/Config/Admin.pm +++ b/Bugzilla/Config/Admin.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Admin; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Advanced.pm b/Bugzilla/Config/Advanced.pm index fa5b7d249..eec2816d2 100644 --- a/Bugzilla/Config/Advanced.pm +++ b/Bugzilla/Config/Advanced.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Config::Advanced; + +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Attachment.pm b/Bugzilla/Config/Attachment.pm index ba19f7782..f31e57254 100644 --- a/Bugzilla/Config/Attachment.pm +++ b/Bugzilla/Config/Attachment.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Attachment; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Auth.pm b/Bugzilla/Config/Auth.pm index 19ba59b0c..579f86ad8 100644 --- a/Bugzilla/Config/Auth.pm +++ b/Bugzilla/Config/Auth.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Auth; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/BugChange.pm b/Bugzilla/Config/BugChange.pm index 68cfe5676..53fc68d00 100644 --- a/Bugzilla/Config/BugChange.pm +++ b/Bugzilla/Config/BugChange.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::BugChange; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/BugFields.pm b/Bugzilla/Config/BugFields.pm index 7ae9ae355..e24f75661 100644 --- a/Bugzilla/Config/BugFields.pm +++ b/Bugzilla/Config/BugFields.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::BugFields; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Common.pm b/Bugzilla/Config/Common.pm index 0e3551d13..32e8ba569 100644 --- a/Bugzilla/Config/Common.pm +++ b/Bugzilla/Config/Common.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Common; +use 5.10.1; use strict; use Email::Address; diff --git a/Bugzilla/Config/Core.pm b/Bugzilla/Config/Core.pm index f2510d2b2..faf86c567 100644 --- a/Bugzilla/Config/Core.pm +++ b/Bugzilla/Config/Core.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Core; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/DependencyGraph.pm b/Bugzilla/Config/DependencyGraph.pm index cc61e3588..42f34e30e 100644 --- a/Bugzilla/Config/DependencyGraph.pm +++ b/Bugzilla/Config/DependencyGraph.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::DependencyGraph; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/General.pm b/Bugzilla/Config/General.pm index 6e00b202a..a401e98ed 100644 --- a/Bugzilla/Config/General.pm +++ b/Bugzilla/Config/General.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Config::General; + +use 5.10.1; use strict; + use Bugzilla::Config::Common; our $sortkey = 150; diff --git a/Bugzilla/Config/GroupSecurity.pm b/Bugzilla/Config/GroupSecurity.pm index 54f5935a6..d5f02f42d 100644 --- a/Bugzilla/Config/GroupSecurity.pm +++ b/Bugzilla/Config/GroupSecurity.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::GroupSecurity; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/LDAP.pm b/Bugzilla/Config/LDAP.pm index daa7f72bb..4a46f40d2 100644 --- a/Bugzilla/Config/LDAP.pm +++ b/Bugzilla/Config/LDAP.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::LDAP; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/MTA.pm b/Bugzilla/Config/MTA.pm index bf038cf49..a6ca36613 100644 --- a/Bugzilla/Config/MTA.pm +++ b/Bugzilla/Config/MTA.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::MTA; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/PatchViewer.pm b/Bugzilla/Config/PatchViewer.pm index 08e8028f3..2005e4c4a 100644 --- a/Bugzilla/Config/PatchViewer.pm +++ b/Bugzilla/Config/PatchViewer.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::PatchViewer; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/Query.pm b/Bugzilla/Config/Query.pm index fe54d67ab..e1287386b 100644 --- a/Bugzilla/Config/Query.pm +++ b/Bugzilla/Config/Query.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::Query; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/RADIUS.pm b/Bugzilla/Config/RADIUS.pm index 312be1ded..17fbdd7dd 100644 --- a/Bugzilla/Config/RADIUS.pm +++ b/Bugzilla/Config/RADIUS.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::RADIUS; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/ShadowDB.pm b/Bugzilla/Config/ShadowDB.pm index c0ff59096..65c572980 100644 --- a/Bugzilla/Config/ShadowDB.pm +++ b/Bugzilla/Config/ShadowDB.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::ShadowDB; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Config/UserMatch.pm b/Bugzilla/Config/UserMatch.pm index 5b98a25ea..53fb5136f 100644 --- a/Bugzilla/Config/UserMatch.pm +++ b/Bugzilla/Config/UserMatch.pm @@ -7,6 +7,7 @@ package Bugzilla::Config::UserMatch; +use 5.10.1; use strict; use Bugzilla::Config::Common; diff --git a/Bugzilla/Constants.pm b/Bugzilla/Constants.pm index c02558faa..1ec921835 100644 --- a/Bugzilla/Constants.pm +++ b/Bugzilla/Constants.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Constants; + +use 5.10.1; use strict; + use base qw(Exporter); # For bz_locations diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm index 7d289aaa1..7756ff53b 100644 --- a/Bugzilla/DB.pm +++ b/Bugzilla/DB.pm @@ -7,6 +7,7 @@ package Bugzilla::DB; +use 5.10.1; use strict; use DBI; diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm index 90bacc02a..9cfa83462 100644 --- a/Bugzilla/DB/Mysql.pm +++ b/Bugzilla/DB/Mysql.pm @@ -20,7 +20,10 @@ For interface details see L<Bugzilla::DB> and L<DBI>. =cut package Bugzilla::DB::Mysql; + +use 5.10.1; use strict; + use base qw(Bugzilla::DB); use Bugzilla::Constants; diff --git a/Bugzilla/DB/Oracle.pm b/Bugzilla/DB/Oracle.pm index f5045b2c7..3f7bc2b87 100644 --- a/Bugzilla/DB/Oracle.pm +++ b/Bugzilla/DB/Oracle.pm @@ -20,7 +20,10 @@ For interface details see L<Bugzilla::DB> and L<DBI>. =cut package Bugzilla::DB::Oracle; + +use 5.10.1; use strict; + use base qw(Bugzilla::DB); use DBD::Oracle; @@ -706,6 +709,10 @@ sub _get_create_trigger_ddl { ############################################################################ package Bugzilla::DB::Oracle::st; + +use 5.10.1; +use strict; + use base qw(DBI::st); sub fetchrow_arrayref { diff --git a/Bugzilla/DB/Pg.pm b/Bugzilla/DB/Pg.pm index c794bdcc5..80bfb4f5f 100644 --- a/Bugzilla/DB/Pg.pm +++ b/Bugzilla/DB/Pg.pm @@ -21,6 +21,7 @@ For interface details see L<Bugzilla::DB> and L<DBI>. package Bugzilla::DB::Pg; +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/DB/Schema.pm b/Bugzilla/DB/Schema.pm index eabee07c3..eb46aa80f 100644 --- a/Bugzilla/DB/Schema.pm +++ b/Bugzilla/DB/Schema.pm @@ -15,7 +15,9 @@ package Bugzilla::DB::Schema; # ########################################################################### +use 5.10.1; use strict; + use Bugzilla::Error; use Bugzilla::Hook; use Bugzilla::Util; diff --git a/Bugzilla/DB/Schema/Mysql.pm b/Bugzilla/DB/Schema/Mysql.pm index 020549a89..8b06dc42b 100644 --- a/Bugzilla/DB/Schema/Mysql.pm +++ b/Bugzilla/DB/Schema/Mysql.pm @@ -13,7 +13,9 @@ package Bugzilla::DB::Schema::Mysql; # ############################################################################### +use 5.10.1; use strict; + use Bugzilla::Error; use base qw(Bugzilla::DB::Schema); diff --git a/Bugzilla/DB/Schema/Oracle.pm b/Bugzilla/DB/Schema/Oracle.pm index 381906d2e..26141c5f4 100644 --- a/Bugzilla/DB/Schema/Oracle.pm +++ b/Bugzilla/DB/Schema/Oracle.pm @@ -13,6 +13,7 @@ package Bugzilla::DB::Schema::Oracle; # ############################################################################### +use 5.10.1; use strict; use base qw(Bugzilla::DB::Schema); diff --git a/Bugzilla/DB/Schema/Pg.pm b/Bugzilla/DB/Schema/Pg.pm index 3dc0fe85e..8dcd09b89 100644 --- a/Bugzilla/DB/Schema/Pg.pm +++ b/Bugzilla/DB/Schema/Pg.pm @@ -13,7 +13,9 @@ package Bugzilla::DB::Schema::Pg; # ############################################################################### +use 5.10.1; use strict; + use base qw(Bugzilla::DB::Schema); use Storable qw(dclone); diff --git a/Bugzilla/DB/Schema/Sqlite.pm b/Bugzilla/DB/Schema/Sqlite.pm index 4cfc2b052..780764a69 100644 --- a/Bugzilla/DB/Schema/Sqlite.pm +++ b/Bugzilla/DB/Schema/Sqlite.pm @@ -5,8 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; package Bugzilla::DB::Schema::Sqlite; + +use 5.10.1; +use strict; + use base qw(Bugzilla::DB::Schema); use Bugzilla::Error; diff --git a/Bugzilla/DB/Sqlite.pm b/Bugzilla/DB/Sqlite.pm index f27ad7143..5564e21df 100644 --- a/Bugzilla/DB/Sqlite.pm +++ b/Bugzilla/DB/Sqlite.pm @@ -5,8 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; package Bugzilla::DB::Sqlite; + +use 5.10.1; +use strict; + use base qw(Bugzilla::DB); use Bugzilla::Constants; diff --git a/Bugzilla/Error.pm b/Bugzilla/Error.pm index e1df5ddbb..03fc8d642 100644 --- a/Bugzilla/Error.pm +++ b/Bugzilla/Error.pm @@ -7,7 +7,9 @@ package Bugzilla::Error; +use 5.10.1; use strict; + use base qw(Exporter); @Bugzilla::Error::EXPORT = qw(ThrowCodeError ThrowTemplateError ThrowUserError); diff --git a/Bugzilla/Extension.pm b/Bugzilla/Extension.pm index 49422eca3..a02a2783a 100644 --- a/Bugzilla/Extension.pm +++ b/Bugzilla/Extension.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Extension; + +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Field.pm b/Bugzilla/Field.pm index 228bea737..64d5da574 100644 --- a/Bugzilla/Field.pm +++ b/Bugzilla/Field.pm @@ -57,6 +57,7 @@ in addition to what is documented here. package Bugzilla::Field; +use 5.10.1; use strict; use base qw(Exporter Bugzilla::Object); diff --git a/Bugzilla/Field/Choice.pm b/Bugzilla/Field/Choice.pm index 8c5873fdb..2b6d8195f 100644 --- a/Bugzilla/Field/Choice.pm +++ b/Bugzilla/Field/Choice.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Field::Choice; +use 5.10.1; +use strict; + use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use Bugzilla::Config qw(SetParam write_params); diff --git a/Bugzilla/Field/ChoiceInterface.pm b/Bugzilla/Field/ChoiceInterface.pm index ad0a61487..c6ca2bc2d 100644 --- a/Bugzilla/Field/ChoiceInterface.pm +++ b/Bugzilla/Field/ChoiceInterface.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Field::ChoiceInterface; + +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm index 22a42d773..5c77eb7cf 100644 --- a/Bugzilla/Flag.pm +++ b/Bugzilla/Flag.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Flag; +use 5.10.1; +use strict; + =head1 NAME Bugzilla::Flag - A module to deal with Bugzilla flag values. diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm index d313a62b9..7f29c4266 100644 --- a/Bugzilla/FlagType.pm +++ b/Bugzilla/FlagType.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::FlagType; +use 5.10.1; +use strict; + =head1 NAME Bugzilla::FlagType - A module to deal with Bugzilla flag types. diff --git a/Bugzilla/Group.pm b/Bugzilla/Group.pm index 2d4e5a0a4..a5b108723 100644 --- a/Bugzilla/Group.pm +++ b/Bugzilla/Group.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Group; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Hook.pm b/Bugzilla/Hook.pm index 3b8b52805..5ac07046e 100644 --- a/Bugzilla/Hook.pm +++ b/Bugzilla/Hook.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Hook; + +use 5.10.1; use strict; sub process { diff --git a/Bugzilla/Install.pm b/Bugzilla/Install.pm index 4954dbfd0..d36bd2d72 100644 --- a/Bugzilla/Install.pm +++ b/Bugzilla/Install.pm @@ -15,6 +15,7 @@ package Bugzilla::Install; # make those assumptions, then it should go into one of the # packages under the Bugzilla::Install namespace. +use 5.10.1; use strict; use Bugzilla::Component; @@ -25,7 +26,7 @@ use Bugzilla::Group; use Bugzilla::Product; use Bugzilla::User; use Bugzilla::User::Setting; -use Bugzilla::Util qw(get_text say); +use Bugzilla::Util qw(get_text); use Bugzilla::Version; use constant STATUS_WORKFLOW => ( diff --git a/Bugzilla/Install/CPAN.pm b/Bugzilla/Install/CPAN.pm index 10e0cce66..a0f059927 100644 --- a/Bugzilla/Install/CPAN.pm +++ b/Bugzilla/Install/CPAN.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Install::CPAN; + +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT = qw( BZ_LIB diff --git a/Bugzilla/Install/DB.pm b/Bugzilla/Install/DB.pm index a6f088482..abf57ac27 100644 --- a/Bugzilla/Install/DB.pm +++ b/Bugzilla/Install/DB.pm @@ -10,6 +10,7 @@ package Bugzilla::Install::DB; # NOTE: This package may "use" any modules that it likes, # localconfig is available, and params are up to date. +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Filesystem.pm b/Bugzilla/Install/Filesystem.pm index cf61a6ec2..6b768cbbb 100644 --- a/Bugzilla/Install/Filesystem.pm +++ b/Bugzilla/Install/Filesystem.pm @@ -15,6 +15,7 @@ package Bugzilla::Install::Filesystem; # * Files do not have the correct permissions. # * The database does not exist. +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Localconfig.pm b/Bugzilla/Install/Localconfig.pm index 4f1579c86..4e54da3cf 100644 --- a/Bugzilla/Install/Localconfig.pm +++ b/Bugzilla/Install/Localconfig.pm @@ -15,6 +15,7 @@ package Bugzilla::Install::Localconfig; # * Files do not have the correct permissions # * The database is not up to date +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm index 24aa1cb82..5dbb8344a 100644 --- a/Bugzilla/Install/Requirements.pm +++ b/Bugzilla/Install/Requirements.pm @@ -13,6 +13,7 @@ package Bugzilla::Install::Requirements; # Subroutines may "require" and "import" from modules, but they # MUST NOT "use." +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Install/Util.pm b/Bugzilla/Install/Util.pm index ed23d0093..8548717e4 100644 --- a/Bugzilla/Install/Util.pm +++ b/Bugzilla/Install/Util.pm @@ -11,6 +11,7 @@ package Bugzilla::Install::Util; # module may require *only* Bugzilla::Constants and built-in # perl modules. +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Job/Mailer.pm b/Bugzilla/Job/Mailer.pm index 958089e45..d6f08adab 100644 --- a/Bugzilla/Job/Mailer.pm +++ b/Bugzilla/Job/Mailer.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Job::Mailer; + +use 5.10.1; use strict; + use Bugzilla::Mailer; BEGIN { eval "use base qw(TheSchwartz::Worker)"; } diff --git a/Bugzilla/JobQueue.pm b/Bugzilla/JobQueue.pm index f8bd6a615..18723446c 100644 --- a/Bugzilla/JobQueue.pm +++ b/Bugzilla/JobQueue.pm @@ -7,6 +7,7 @@ package Bugzilla::JobQueue; +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/JobQueue/Runner.pm b/Bugzilla/JobQueue/Runner.pm index 6c837369f..e38e6ce59 100644 --- a/Bugzilla/JobQueue/Runner.pm +++ b/Bugzilla/JobQueue/Runner.pm @@ -11,7 +11,9 @@ package Bugzilla::JobQueue::Runner; +use 5.10.1; use strict; + use Cwd qw(abs_path); use File::Basename; use File::Copy; diff --git a/Bugzilla/Keyword.pm b/Bugzilla/Keyword.pm index a6e0b6d27..b933c11f8 100644 --- a/Bugzilla/Keyword.pm +++ b/Bugzilla/Keyword.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Keyword; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Error; diff --git a/Bugzilla/Mailer.pm b/Bugzilla/Mailer.pm index 5ef731063..203121de1 100644 --- a/Bugzilla/Mailer.pm +++ b/Bugzilla/Mailer.pm @@ -7,6 +7,7 @@ package Bugzilla::Mailer; +use 5.10.1; use strict; use base qw(Exporter); diff --git a/Bugzilla/Migrate.pm b/Bugzilla/Migrate.pm index 0975a0633..6dbe6ef10 100644 --- a/Bugzilla/Migrate.pm +++ b/Bugzilla/Migrate.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Migrate; + +use 5.10.1; use strict; use Bugzilla::Attachment; @@ -16,7 +18,7 @@ use Bugzilla::Error; use Bugzilla::Install::Requirements (); use Bugzilla::Install::Util qw(indicate_progress); use Bugzilla::Product; -use Bugzilla::Util qw(get_text trim generate_random_password say); +use Bugzilla::Util qw(get_text trim generate_random_password); use Bugzilla::User (); use Bugzilla::Status (); use Bugzilla::Version; diff --git a/Bugzilla/Migrate/Gnats.pm b/Bugzilla/Migrate/Gnats.pm index 05d3b3739..6022bdbbb 100644 --- a/Bugzilla/Migrate/Gnats.pm +++ b/Bugzilla/Migrate/Gnats.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Migrate::Gnats; + +use 5.10.1; use strict; + use base qw(Bugzilla::Migrate); use Bugzilla::Constants; diff --git a/Bugzilla/Milestone.pm b/Bugzilla/Milestone.pm index ef8ecbab5..8f243232d 100644 --- a/Bugzilla/Milestone.pm +++ b/Bugzilla/Milestone.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Milestone; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Object.pm b/Bugzilla/Object.pm index 531b81711..fa4c4e790 100644 --- a/Bugzilla/Object.pm +++ b/Bugzilla/Object.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Object; +use 5.10.1; +use strict; + use Bugzilla::Constants; use Bugzilla::Hook; use Bugzilla::Util; diff --git a/Bugzilla/Product.pm b/Bugzilla/Product.pm index fdebc6b00..894db422e 100644 --- a/Bugzilla/Product.pm +++ b/Bugzilla/Product.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Product; + +use 5.10.1; use strict; + use base qw(Bugzilla::Field::ChoiceInterface Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/RNG.pm b/Bugzilla/RNG.pm index 457d2cae0..59eb3195c 100644 --- a/Bugzilla/RNG.pm +++ b/Bugzilla/RNG.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::RNG; + +use 5.10.1; use strict; + use base qw(Exporter); use Bugzilla::Constants qw(ON_WINDOWS); diff --git a/Bugzilla/Report.pm b/Bugzilla/Report.pm index 4c9f33226..097bbb074 100644 --- a/Bugzilla/Report.pm +++ b/Bugzilla/Report.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Report; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::CGI; diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index aaa3c208b..c64ff6de2 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -5,9 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +package Bugzilla::Search; + +use 5.10.1; use strict; -package Bugzilla::Search; use base qw(Exporter); @Bugzilla::Search::EXPORT = qw( IsValidQueryType diff --git a/Bugzilla/Search/Clause.pm b/Bugzilla/Search/Clause.pm index 6e682e7cf..ff50cb944 100644 --- a/Bugzilla/Search/Clause.pm +++ b/Bugzilla/Search/Clause.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Search::Clause; + +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/Search/Condition.pm b/Bugzilla/Search/Condition.pm index 2ca723727..ac6947484 100644 --- a/Bugzilla/Search/Condition.pm +++ b/Bugzilla/Search/Condition.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Search::Condition; + +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT_OK = qw(condition); diff --git a/Bugzilla/Search/Quicksearch.pm b/Bugzilla/Search/Quicksearch.pm index 17c5635ff..d686fde03 100644 --- a/Bugzilla/Search/Quicksearch.pm +++ b/Bugzilla/Search/Quicksearch.pm @@ -7,7 +7,7 @@ package Bugzilla::Search::Quicksearch; -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/Search/Recent.pm b/Bugzilla/Search/Recent.pm index 02c3ec37a..00b71a91d 100644 --- a/Bugzilla/Search/Recent.pm +++ b/Bugzilla/Search/Recent.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Search::Recent; + +use 5.10.1; use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Search/Saved.pm b/Bugzilla/Search/Saved.pm index c9885c9ce..f6e9badab 100644 --- a/Bugzilla/Search/Saved.pm +++ b/Bugzilla/Search/Saved.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Search::Saved; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::CGI; diff --git a/Bugzilla/Send/Sendmail.pm b/Bugzilla/Send/Sendmail.pm index 9513134f4..b15f48043 100644 --- a/Bugzilla/Send/Sendmail.pm +++ b/Bugzilla/Send/Sendmail.pm @@ -7,6 +7,7 @@ package Bugzilla::Send::Sendmail; +use 5.10.1; use strict; use base qw(Email::Send::Sendmail); diff --git a/Bugzilla/Series.pm b/Bugzilla/Series.pm index f2ed9a4af..e7c2ef005 100644 --- a/Bugzilla/Series.pm +++ b/Bugzilla/Series.pm @@ -5,8 +5,6 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - # This module implements a series - a set of data to be plotted on a chart. # # This Series is in the database if and only if self->{'series_id'} is defined. @@ -16,6 +14,9 @@ use strict; package Bugzilla::Series; +use 5.10.1; +use strict; + use Bugzilla::Error; use Bugzilla::Util; diff --git a/Bugzilla/Status.pm b/Bugzilla/Status.pm index 2821f7c6e..33277fed7 100644 --- a/Bugzilla/Status.pm +++ b/Bugzilla/Status.pm @@ -5,11 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Status; -use Bugzilla::Error; +use 5.10.1; +use strict; + # This subclasses Bugzilla::Field::Choice instead of implementing # ChoiceInterface, because a bug status literally is a special type # of Field::Choice, not just an object that happens to have the same @@ -23,6 +23,8 @@ use base qw(Bugzilla::Field::Choice Exporter); closed_bug_statuses ); +use Bugzilla::Error; + ################################ ##### Initialization ##### ################################ diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index a38d07e7f..6685a7431 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -8,6 +8,7 @@ package Bugzilla::Template; +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/Template/Context.pm b/Bugzilla/Template/Context.pm index 9dc1f08f9..937ac33b1 100644 --- a/Bugzilla/Template/Context.pm +++ b/Bugzilla/Template/Context.pm @@ -7,7 +7,10 @@ # This exists to implement the template-before_process hook. package Bugzilla::Template::Context; + +use 5.10.1; use strict; + use base qw(Template::Context); use Bugzilla::Hook; diff --git a/Bugzilla/Template/Plugin/Bugzilla.pm b/Bugzilla/Template/Plugin/Bugzilla.pm index e2b59c7a8..044c9eed1 100644 --- a/Bugzilla/Template/Plugin/Bugzilla.pm +++ b/Bugzilla/Template/Plugin/Bugzilla.pm @@ -7,6 +7,7 @@ package Bugzilla::Template::Plugin::Bugzilla; +use 5.10.1; use strict; use base qw(Template::Plugin); diff --git a/Bugzilla/Template/Plugin/Hook.pm b/Bugzilla/Template/Plugin/Hook.pm index f1de7a602..52b3703dc 100644 --- a/Bugzilla/Template/Plugin/Hook.pm +++ b/Bugzilla/Template/Plugin/Hook.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::Template::Plugin::Hook; + +use 5.10.1; use strict; + use base qw(Template::Plugin); use Bugzilla::Constants; diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm index 264a28db1..f7caa0e31 100644 --- a/Bugzilla/Token.pm +++ b/Bugzilla/Token.pm @@ -5,16 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Module Initialization -################################################################################ +package Bugzilla::Token; -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; -# Bundle the functions in this file together into the "Bugzilla::Token" package. -package Bugzilla::Token; - use Bugzilla::Constants; use Bugzilla::Error; use Bugzilla::Mailer; diff --git a/Bugzilla/Update.pm b/Bugzilla/Update.pm index 29133ecce..6a1012199 100644 --- a/Bugzilla/Update.pm +++ b/Bugzilla/Update.pm @@ -7,6 +7,7 @@ package Bugzilla::Update; +use 5.10.1; use strict; use Bugzilla::Constants; diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm index 0bf945084..87255b20a 100644 --- a/Bugzilla/User.pm +++ b/Bugzilla/User.pm @@ -5,16 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Module Initialization -################################################################################ +package Bugzilla::User; -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; -# This module implements utilities for dealing with Bugzilla users. -package Bugzilla::User; - use Bugzilla::Error; use Bugzilla::Util; use Bugzilla::Constants; diff --git a/Bugzilla/User/Setting.pm b/Bugzilla/User/Setting.pm index 6fadfb352..52a5ff5aa 100644 --- a/Bugzilla/User/Setting.pm +++ b/Bugzilla/User/Setting.pm @@ -8,7 +8,9 @@ package Bugzilla::User::Setting; +use 5.10.1; use strict; + use base qw(Exporter); diff --git a/Bugzilla/User/Setting/Lang.pm b/Bugzilla/User/Setting/Lang.pm index 71b01d62f..0dcec9aa1 100644 --- a/Bugzilla/User/Setting/Lang.pm +++ b/Bugzilla/User/Setting/Lang.pm @@ -7,6 +7,7 @@ package Bugzilla::User::Setting::Lang; +use 5.10.1; use strict; use base qw(Bugzilla::User::Setting); diff --git a/Bugzilla/User/Setting/Skin.pm b/Bugzilla/User/Setting/Skin.pm index c75ce7568..3181fdded 100644 --- a/Bugzilla/User/Setting/Skin.pm +++ b/Bugzilla/User/Setting/Skin.pm @@ -8,6 +8,7 @@ package Bugzilla::User::Setting::Skin; +use 5.10.1; use strict; use base qw(Bugzilla::User::Setting); diff --git a/Bugzilla/User/Setting/Timezone.pm b/Bugzilla/User/Setting/Timezone.pm index 91f997774..962e0a7ff 100644 --- a/Bugzilla/User/Setting/Timezone.pm +++ b/Bugzilla/User/Setting/Timezone.pm @@ -7,6 +7,7 @@ package Bugzilla::User::Setting::Timezone; +use 5.10.1; use strict; use DateTime::TimeZone; diff --git a/Bugzilla/UserAgent.pm b/Bugzilla/UserAgent.pm index b5d552130..627120efc 100644 --- a/Bugzilla/UserAgent.pm +++ b/Bugzilla/UserAgent.pm @@ -7,7 +7,9 @@ package Bugzilla::UserAgent; +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT = qw(detect_platform detect_op_sys); diff --git a/Bugzilla/Util.pm b/Bugzilla/Util.pm index 78ef21e1d..9e1a01e2d 100644 --- a/Bugzilla/Util.pm +++ b/Bugzilla/Util.pm @@ -7,8 +7,8 @@ package Bugzilla::Util; +use 5.10.1; use strict; -use feature ':5.10'; use base qw(Exporter); @Bugzilla::Util::EXPORT = qw(trick_taint detaint_natural detaint_signed @@ -16,7 +16,7 @@ use base qw(Exporter); css_class_quote html_light_quote i_am_cgi correct_urlbase remote_ip validate_ip do_ssl_redirect_if_required use_attachbase - diff_arrays on_main_db say + diff_arrays on_main_db trim wrap_hard wrap_comment find_wrap_point format_time validate_date validate_time datetime_from is_7bit_clean bz_crypt generate_random_password diff --git a/Bugzilla/Version.pm b/Bugzilla/Version.pm index 02f2a70d8..449630a6d 100644 --- a/Bugzilla/Version.pm +++ b/Bugzilla/Version.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Version; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Install::Util qw(vers_cmp); diff --git a/Bugzilla/WebService.pm b/Bugzilla/WebService.pm index 88ffa3f96..38e0f510f 100644 --- a/Bugzilla/WebService.pm +++ b/Bugzilla/WebService.pm @@ -8,7 +8,10 @@ # This is the base class for $self in WebService method calls. For the # actual RPC server, see Bugzilla::WebService::Server and its subclasses. package Bugzilla::WebService; + +use 5.10.1; use strict; + use Bugzilla::WebService::Server; # Used by the JSON-RPC server to convert incoming date fields apprpriately. diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm index 75c3c2f61..1c8811b65 100644 --- a/Bugzilla/WebService/Bug.pm +++ b/Bugzilla/WebService/Bug.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Bug; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Comment; diff --git a/Bugzilla/WebService/Bugzilla.pm b/Bugzilla/WebService/Bugzilla.pm index f441cee90..471110566 100644 --- a/Bugzilla/WebService/Bugzilla.pm +++ b/Bugzilla/WebService/Bugzilla.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Bugzilla; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Constants; use Bugzilla::Util qw(datetime_from); diff --git a/Bugzilla/WebService/Constants.pm b/Bugzilla/WebService/Constants.pm index 491970291..dcd3a9fd7 100644 --- a/Bugzilla/WebService/Constants.pm +++ b/Bugzilla/WebService/Constants.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Constants; +use 5.10.1; use strict; + use base qw(Exporter); our @EXPORT = qw( diff --git a/Bugzilla/WebService/Group.pm b/Bugzilla/WebService/Group.pm index d7506aa3d..79ce1658b 100644 --- a/Bugzilla/WebService/Group.pm +++ b/Bugzilla/WebService/Group.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Group; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Constants; use Bugzilla::Error; diff --git a/Bugzilla/WebService/Product.pm b/Bugzilla/WebService/Product.pm index 18594d726..8d6fc5df2 100644 --- a/Bugzilla/WebService/Product.pm +++ b/Bugzilla/WebService/Product.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Product; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); use Bugzilla::Product; use Bugzilla::User; diff --git a/Bugzilla/WebService/Server.pm b/Bugzilla/WebService/Server.pm index a43ed204c..5f1795178 100644 --- a/Bugzilla/WebService/Server.pm +++ b/Bugzilla/WebService/Server.pm @@ -6,6 +6,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::WebService::Server; + +use 5.10.1; use strict; use Bugzilla::Error; diff --git a/Bugzilla/WebService/Server/JSONRPC.pm b/Bugzilla/WebService/Server/JSONRPC.pm index 804d7874e..46dd6b8da 100644 --- a/Bugzilla/WebService/Server/JSONRPC.pm +++ b/Bugzilla/WebService/Server/JSONRPC.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Server::JSONRPC; +use 5.10.1; use strict; + use Bugzilla::WebService::Server; BEGIN { our @ISA = qw(Bugzilla::WebService::Server); diff --git a/Bugzilla/WebService/Server/XMLRPC.pm b/Bugzilla/WebService/Server/XMLRPC.pm index e8fb5de99..22396bce1 100644 --- a/Bugzilla/WebService/Server/XMLRPC.pm +++ b/Bugzilla/WebService/Server/XMLRPC.pm @@ -7,7 +7,9 @@ package Bugzilla::WebService::Server::XMLRPC; +use 5.10.1; use strict; + use XMLRPC::Transport::HTTP; use Bugzilla::WebService::Server; if ($ENV{MOD_PERL}) { @@ -66,7 +68,10 @@ sub handle_login { # This exists to validate input parameters (which XMLRPC::Lite doesn't do) # and also, in some cases, to more-usefully decode them. package Bugzilla::XMLRPC::Deserializer; + +use 5.10.1; use strict; + # We can't use "use base" because XMLRPC::Serializer doesn't return # a true value. use XMLRPC::Lite; @@ -161,7 +166,10 @@ sub _validation_subs { 1; package Bugzilla::XMLRPC::SOM; + +use 5.10.1; use strict; + use XMLRPC::Lite; our @ISA = qw(XMLRPC::SOM); use Bugzilla::WebService::Util qw(taint_data); @@ -184,8 +192,11 @@ sub paramsin { # This package exists to fix a UTF-8 bug in SOAP::Lite. # See http://rt.cpan.org/Public/Bug/Display.html?id=32952. package Bugzilla::XMLRPC::Serializer; -use Scalar::Util qw(blessed); + +use 5.10.1; use strict; + +use Scalar::Util qw(blessed); # We can't use "use base" because XMLRPC::Serializer doesn't return # a true value. use XMLRPC::Lite; diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm index 05bbf90ca..ee1442d72 100644 --- a/Bugzilla/WebService/User.pm +++ b/Bugzilla/WebService/User.pm @@ -7,10 +7,11 @@ package Bugzilla::WebService::User; +use 5.10.1; use strict; + use base qw(Bugzilla::WebService); -use Bugzilla; use Bugzilla::Constants; use Bugzilla::Error; use Bugzilla::Group; diff --git a/Bugzilla/WebService/Util.pm b/Bugzilla/WebService/Util.pm index 83b925015..0c206e030 100644 --- a/Bugzilla/WebService/Util.pm +++ b/Bugzilla/WebService/Util.pm @@ -6,7 +6,10 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::WebService::Util; + +use 5.10.1; use strict; + use base qw(Exporter); # We have to "require", not "use" this, because otherwise it tries to diff --git a/Bugzilla/Whine.pm b/Bugzilla/Whine.pm index 379619822..fba6e714a 100644 --- a/Bugzilla/Whine.pm +++ b/Bugzilla/Whine.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Whine; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; diff --git a/Bugzilla/Whine/Query.pm b/Bugzilla/Whine/Query.pm index e52cad66e..3c63e8057 100644 --- a/Bugzilla/Whine/Query.pm +++ b/Bugzilla/Whine/Query.pm @@ -7,6 +7,7 @@ package Bugzilla::Whine::Query; +use 5.10.1; use strict; use base qw(Bugzilla::Object); diff --git a/Bugzilla/Whine/Schedule.pm b/Bugzilla/Whine/Schedule.pm index 102b5d825..a96c728f2 100644 --- a/Bugzilla/Whine/Schedule.pm +++ b/Bugzilla/Whine/Schedule.pm @@ -5,10 +5,11 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -use strict; - package Bugzilla::Whine::Schedule; +use 5.10.1; +use strict; + use base qw(Bugzilla::Object); use Bugzilla::Constants; @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/attachment.cgi b/attachment.cgi index e696c95a7..775a91f00 100755 --- a/attachment.cgi +++ b/attachment.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -24,11 +19,9 @@ use Bugzilla::FlagType; use Bugzilla::User; use Bugzilla::Util; use Bugzilla::Bug; -use Bugzilla::Field; use Bugzilla::Attachment; use Bugzilla::Attachment::PatchReader; use Bugzilla::Token; -use Bugzilla::Keyword; use Encode qw(encode find_encoding); @@ -40,10 +33,6 @@ local our $cgi = Bugzilla->cgi; local our $template = Bugzilla->template; local our $vars = {}; -################################################################################ -# Main Body Execution -################################################################################ - # All calls to this script should contain an "action" variable whose # value determines what the user wants to do. The code below checks # the value of that variable and runs the appropriate code. If none is diff --git a/buglist.cgi b/buglist.cgi index 8185491d9..057caa935 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -27,6 +27,7 @@ # Bonus: # Offer subscription when you get a "series already exists" error? +use 5.10.1; use strict; use lib qw(. lib); @@ -37,7 +38,6 @@ use Bugzilla::Error; use Bugzilla::Util; use Bugzilla::Chart; use Bugzilla::Series; -use Bugzilla::User; use Bugzilla::Token; # For most scripts we don't make $cgi and $template global variables. But diff --git a/colchange.cgi b/colchange.cgi index 835a8ef34..0aa6c7cba 100755 --- a/colchange.cgi +++ b/colchange.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); @@ -15,7 +16,6 @@ use Bugzilla::Util; use Bugzilla::CGI; use Bugzilla::Search::Saved; use Bugzilla::Error; -use Bugzilla::User; use Bugzilla::Token; use Storable qw(dclone); diff --git a/collectstats.pl b/collectstats.pl index c1ad338f5..7336714bb 100755 --- a/collectstats.pl +++ b/collectstats.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/config.cgi b/config.cgi index 7dc2e3afb..c4f64a007 100755 --- a/config.cgi +++ b/config.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/contrib/Bugzilla.pm b/contrib/Bugzilla.pm index 6bfc07e2a..fbae60de4 100644 --- a/contrib/Bugzilla.pm +++ b/contrib/Bugzilla.pm @@ -4,6 +4,7 @@ package Bugzilla; +use 5.10.1; use strict; ####################################################################### diff --git a/createaccount.cgi b/createaccount.cgi index e3b83205b..e2dbbf62f 100755 --- a/createaccount.cgi +++ b/createaccount.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/describecomponents.cgi b/describecomponents.cgi index 3a70f29bb..8544346af 100755 --- a/describecomponents.cgi +++ b/describecomponents.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/describekeywords.cgi b/describekeywords.cgi index b67b9c3d9..ef0634960 100755 --- a/describekeywords.cgi +++ b/describekeywords.cgi @@ -6,12 +6,12 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); use Bugzilla; use Bugzilla::Error; -use Bugzilla::User; use Bugzilla::Keyword; my $user = Bugzilla->login(); diff --git a/docs/lib/Pod/Simple/HTML/Bugzilla.pm b/docs/lib/Pod/Simple/HTML/Bugzilla.pm index cc607be7c..4a1517671 100644 --- a/docs/lib/Pod/Simple/HTML/Bugzilla.pm +++ b/docs/lib/Pod/Simple/HTML/Bugzilla.pm @@ -7,7 +7,9 @@ package Pod::Simple::HTML::Bugzilla; +use 5.10.1; use strict; + use base qw(Pod::Simple::HTML); # Without this constant, HTMLBatch will throw undef warnings. diff --git a/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm b/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm index 366ceb7a0..52a09910f 100644 --- a/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm +++ b/docs/lib/Pod/Simple/HTMLBatch/Bugzilla.pm @@ -7,7 +7,9 @@ package Pod::Simple::HTMLBatch::Bugzilla; +use 5.10.1; use strict; + use base qw(Pod::Simple::HTMLBatch); # This is the same hack that HTMLBatch does to "import" this subroutine. diff --git a/docs/makedocs.pl b/docs/makedocs.pl index 4bf1fb4a0..ea08d8258 100755 --- a/docs/makedocs.pl +++ b/docs/makedocs.pl @@ -8,7 +8,9 @@ # This script compiles all the documentation. +use 5.10.1; use strict; + use Cwd; # We need to be in this directory to use our libraries. @@ -87,8 +89,8 @@ sub MakeDocs { my ($name, $cmdline) = @_; - print "Creating $name documentation ...\n" if defined $name; - print "$cmdline\n\n"; + say "Creating $name documentation ..." if defined $name; + say "$cmdline\n"; system $cmdline; print "\n"; @@ -96,7 +98,7 @@ sub MakeDocs { sub make_pod { - print "Creating API documentation...\n"; + say "Creating API documentation..."; my $converter = Pod::Simple::HTMLBatch::Bugzilla->new; # Don't output progress information. diff --git a/duplicates.cgi b/duplicates.cgi index 01962218b..d501b0e16 100755 --- a/duplicates.cgi +++ b/duplicates.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editclassifications.cgi b/editclassifications.cgi index 3a2647af6..3d93057b9 100755 --- a/editclassifications.cgi +++ b/editclassifications.cgi @@ -7,6 +7,7 @@ # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editcomponents.cgi b/editcomponents.cgi index 7ff1dae81..12a449fd4 100755 --- a/editcomponents.cgi +++ b/editcomponents.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editfields.cgi b/editfields.cgi index 5d9e05367..5ac9dccce 100755 --- a/editfields.cgi +++ b/editfields.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editflagtypes.cgi b/editflagtypes.cgi index e9c430d7d..c52bab717 100755 --- a/editflagtypes.cgi +++ b/editflagtypes.cgi @@ -6,15 +6,10 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; use lib qw(. lib); -# Use Bugzilla's flag modules for handling flag types. use Bugzilla; use Bugzilla::Constants; use Bugzilla::Flag; diff --git a/editgroups.cgi b/editgroups.cgi index d603ab183..87c44f03c 100755 --- a/editgroups.cgi +++ b/editgroups.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editkeywords.cgi b/editkeywords.cgi index cbaa308fb..7e14f80cd 100755 --- a/editkeywords.cgi +++ b/editkeywords.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editmilestones.cgi b/editmilestones.cgi index 93152cd50..3eeb300ab 100755 --- a/editmilestones.cgi +++ b/editmilestones.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editparams.cgi b/editparams.cgi index b522fd414..3486d7061 100755 --- a/editparams.cgi +++ b/editparams.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editproducts.cgi b/editproducts.cgi index b4f164995..137f14285 100755 --- a/editproducts.cgi +++ b/editproducts.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editsettings.cgi b/editsettings.cgi index 17740cd5c..bf5e2025b 100755 --- a/editsettings.cgi +++ b/editsettings.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editusers.cgi b/editusers.cgi index e2675921b..30a747ded 100755 --- a/editusers.cgi +++ b/editusers.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editvalues.cgi b/editvalues.cgi index 60c39c9ea..61fe24723 100755 --- a/editvalues.cgi +++ b/editvalues.cgi @@ -10,6 +10,7 @@ # or select boxes. It is largely a copy of editmilestones.cgi, but # with some cleanup. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editversions.cgi b/editversions.cgi index 4951c272a..1d056c67b 100755 --- a/editversions.cgi +++ b/editversions.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/editwhines.cgi b/editwhines.cgi index 5227f1d62..e93e552d9 100755 --- a/editwhines.cgi +++ b/editwhines.cgi @@ -10,8 +10,8 @@ # Script Initialization ################################################################################ +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/editworkflow.cgi b/editworkflow.cgi index 36b8ab8f9..68cd98458 100755 --- a/editworkflow.cgi +++ b/editworkflow.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/email_in.pl b/email_in.pl index 6be7be8cf..183833008 100755 --- a/email_in.pl +++ b/email_in.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use warnings; diff --git a/enter_bug.cgi b/enter_bug.cgi index 7a8cebf43..a4dde21ba 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -16,8 +16,8 @@ # ############################################################################## +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/extensions/create.pl b/extensions/create.pl index 5f1b884d2..c48f60df8 100755 --- a/extensions/create.pl +++ b/extensions/create.pl @@ -6,8 +6,10 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); + use Bugzilla; use Bugzilla::Constants; use Bugzilla::Error; @@ -54,7 +56,7 @@ foreach my $template_file (keys %create_files) { close($fh); } -print get_text('extension_created', $vars), "\n"; +say get_text('extension_created', $vars); __END__ diff --git a/importxml.pl b/importxml.pl index f34317d5a..1105e2517 100755 --- a/importxml.pl +++ b/importxml.pl @@ -10,6 +10,7 @@ # a new bug into bugzilla. Everything before the beginning <?xml line # is removed so you can pipe in email messages. +use 5.10.1; use strict; ##################################################################### @@ -6,14 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -############################################################################### -# Script Initialization -############################################################################### - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - -# Include the Bugzilla CGI and general utility library. use lib qw(. lib); use Bugzilla; @@ -37,10 +31,6 @@ if ($cgi->param('logout')) { $cgi->delete('logout'); } -############################################################################### -# Main Body Execution -############################################################################### - # Return the appropriate HTTP response headers. print $cgi->header(); diff --git a/install-module.pl b/install-module.pl index 466377759..37ea8cc41 100755 --- a/install-module.pl +++ b/install-module.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use warnings; diff --git a/jobqueue.pl b/jobqueue.pl index 1b956917e..6ba288d2e 100755 --- a/jobqueue.pl +++ b/jobqueue.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use Cwd qw(abs_path); diff --git a/jsonrpc.cgi b/jsonrpc.cgi index 0d275f83c..6a60c9d3e 100755 --- a/jsonrpc.cgi +++ b/jsonrpc.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/migrate.pl b/migrate.pl index de4265b0b..0ce85fa15 100755 --- a/migrate.pl +++ b/migrate.pl @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use File::Basename; BEGIN { chdir dirname($0); } diff --git a/mod_perl.pl b/mod_perl.pl index ac6956b1b..81aae301e 100644 --- a/mod_perl.pl +++ b/mod_perl.pl @@ -7,6 +7,8 @@ # defined by the Mozilla Public License, v. 2.0. package Bugzilla::ModPerl; + +use 5.10.1; use strict; use warnings; @@ -107,7 +109,10 @@ foreach my $file (glob "$cgi_path/*.cgi") { } package Bugzilla::ModPerl::ResponseHandler; + +use 5.10.1; use strict; + use base qw(ModPerl::Registry); use Bugzilla; @@ -132,7 +137,10 @@ sub handler : method { package Bugzilla::ModPerl::CleanupHandler; + +use 5.10.1; use strict; + use Apache2::Const -compile => qw(OK); sub handler { @@ -13,8 +13,8 @@ # a content-type, e.g. html. ############################################################################### +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/post_bug.cgi b/post_bug.cgi index b15049234..b38707365 100755 --- a/post_bug.cgi +++ b/post_bug.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); @@ -17,11 +18,7 @@ use Bugzilla::Util; use Bugzilla::Error; use Bugzilla::Bug; use Bugzilla::User; -use Bugzilla::Field; use Bugzilla::Hook; -use Bugzilla::Product; -use Bugzilla::Component; -use Bugzilla::Keyword; use Bugzilla::Token; use Bugzilla::Flag; diff --git a/process_bug.cgi b/process_bug.cgi index 29cc54e9f..d9ae9c109 100755 --- a/process_bug.cgi +++ b/process_bug.cgi @@ -18,8 +18,8 @@ # 3) If we are processing just the one id, then it is stored in @idlist for # later processing. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/relogin.cgi b/relogin.cgi index 57240db43..e2effd105 100755 --- a/relogin.cgi +++ b/relogin.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/report.cgi b/report.cgi index 0241f42b5..a5d170825 100755 --- a/report.cgi +++ b/report.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/reports.cgi b/reports.cgi index 66f4b05d7..c8c319f41 100755 --- a/reports.cgi +++ b/reports.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/request.cgi b/request.cgi index 3bae8c094..17e6c926d 100755 --- a/request.cgi +++ b/request.cgi @@ -6,13 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -################################################################################ -# Script Initialization -################################################################################ - -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -34,10 +29,6 @@ my $action = $cgi->param('action') || ''; print $cgi->header(); -################################################################################ -# Main Body Execution -################################################################################ - my $fields; $fields->{'requester'}->{'type'} = 'single'; # If the user doesn't restrict his search to requests from the wind diff --git a/runtests.pl b/runtests.pl index 09963e84e..6a6450007 100755 --- a/runtests.pl +++ b/runtests.pl @@ -6,7 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. -# Make it harder for us to do dangerous things in Perl. +use 5.10.1; use diagnostics; use strict; use lib qw(lib); diff --git a/sanitycheck.cgi b/sanitycheck.cgi index 3a869ef9f..ad5925d06 100755 --- a/sanitycheck.cgi +++ b/sanitycheck.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/sanitycheck.pl b/sanitycheck.pl index a360bf8c0..819c66152 100755 --- a/sanitycheck.pl +++ b/sanitycheck.pl @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/search_plugin.cgi b/search_plugin.cgi index 3809159c7..e9b281ec2 100755 --- a/search_plugin.cgi +++ b/search_plugin.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/show_activity.cgi b/show_activity.cgi index d161382f7..31181a63b 100755 --- a/show_activity.cgi +++ b/show_activity.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/show_bug.cgi b/show_bug.cgi index 48d75512b..e5ae4bfd0 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index 842e12f2a..ff0602d46 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use File::Temp; diff --git a/showdependencytree.cgi b/showdependencytree.cgi index f8844b702..4031ed263 100755 --- a/showdependencytree.cgi +++ b/showdependencytree.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/summarize_time.cgi b/summarize_time.cgi index fa13a5162..e06d3257d 100755 --- a/summarize_time.cgi +++ b/summarize_time.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Date::Parse; # strptime diff --git a/t/002goodperl.t b/t/002goodperl.t index e691b39dd..4826c7712 100644 --- a/t/002goodperl.t +++ b/t/002goodperl.t @@ -16,7 +16,7 @@ use lib 't'; use Support::Files; -use Test::More tests => (scalar(@Support::Files::testitems) * 3); +use Test::More tests => (scalar(@Support::Files::testitems) * 4); my @testitems = @Support::Files::testitems; # get the files to test. @@ -84,6 +84,28 @@ foreach my $file (@testitems) { } } +foreach my $file (@testitems) { + my $found_use_feature = 0; + $file =~ s/\s.*$//; # nuke everything after the first space (#comment) + next if (!$file); # skip null entries + if (! open (FILE, $file)) { + ok(0,"could not open $file --WARNING"); + next; + } + while (my $file_line = <FILE>) { + if ($file_line =~ m/^\s*use 5.10.1/) { + $found_use_feature = 1; + last; + } + } + close (FILE); + if ($found_use_feature) { + ok(1,"$file requires Perl 5.10.1"); + } else { + ok(0,"$file DOES NOT require Perl 5.10.1 --WARNING"); + } +} + # Check to see that all error messages use tags (for l10n reasons.) foreach my $file (@testitems) { $file =~ s/\s.*$//; # nuke everything after the first space (#comment) diff --git a/testagent.cgi b/testagent.cgi index 3480f877e..c3220cab5 100755 --- a/testagent.cgi +++ b/testagent.cgi @@ -10,7 +10,9 @@ # are being run instead of shown. This script does not rely on database access # or correct params. +use 5.10.1; use strict; -print "content-type:text/plain\n\n"; -print "OK " . ($::ENV{MOD_PERL} || "mod_cgi") . "\n"; + +say "content-type:text/plain\n"; +say "OK " . ($::ENV{MOD_PERL} || "mod_cgi"); exit; diff --git a/testserver.pl b/testserver.pl index 488524792..3eb25a13b 100755 --- a/testserver.pl +++ b/testserver.pl @@ -10,12 +10,12 @@ # as its only argument. It attempts to troubleshoot as many installation # issues as possible. +use 5.10.1; use strict; use lib qw(. lib); use Bugzilla; use Bugzilla::Constants; -use Bugzilla::Util qw(say); use Socket; @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); diff --git a/userprefs.cgi b/userprefs.cgi index 1b6347456..a80184d51 100755 --- a/userprefs.cgi +++ b/userprefs.cgi @@ -6,8 +6,8 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; @@ -9,8 +9,10 @@ # This script remains as a backwards-compatibility URL for before # the time that Voting was an extension. +use 5.10.1; use strict; use lib qw(. lib); + use Bugzilla; use Bugzilla::Error; @@ -10,8 +10,8 @@ # Script Initialization ################################################################################ +use 5.10.1; use strict; - use lib qw(. lib); use Bugzilla; diff --git a/whineatnews.pl b/whineatnews.pl index 4a5c967c6..c81381162 100755 --- a/whineatnews.pl +++ b/whineatnews.pl @@ -14,6 +14,7 @@ # param. (We have NEW and REOPENED in there to keep compatibility with old # Bugzillas.) +use 5.10.1; use strict; use lib qw(. lib); diff --git a/xmlrpc.cgi b/xmlrpc.cgi index 8bf9f9f1e..a8092b25d 100755 --- a/xmlrpc.cgi +++ b/xmlrpc.cgi @@ -6,6 +6,7 @@ # This Source Code Form is "Incompatible With Secondary Licenses", as # defined by the Mozilla Public License, v. 2.0. +use 5.10.1; use strict; use lib qw(. lib); |