summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2009-01-08 01:06:49 +0100
committerlpsolit%gmail.com <>2009-01-08 01:06:49 +0100
commit11fa9ce3596363a4d4badd7960ae73e8dc535050 (patch)
tree3dac3780376ee6d73ed6a2fd0e2801878ef8412d
parent559f89582199e4ca531398a5cadd03632526d525 (diff)
downloadbugzilla-11fa9ce3596363a4d4badd7960ae73e8dc535050.tar.gz
bugzilla-11fa9ce3596363a4d4badd7960ae73e8dc535050.tar.xz
Bug 472549: Ignore undefined values when committing user pref changes - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
-rwxr-xr-xuserprefs.cgi2
1 files changed, 1 insertions, 1 deletions
diff --git a/userprefs.cgi b/userprefs.cgi
index 1bf2d7f5f..085372bac 100755
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -127,7 +127,6 @@ sub SaveAccount {
$cgi->param('Bugzilla_password')
|| ThrowUserError("old_password_required");
- use Bugzilla::Token;
# Block multiple email changes for the same user.
if (Bugzilla::Token::HasEmailChangeToken($user->id)) {
ThrowUserError("email_change_in_progress");
@@ -183,6 +182,7 @@ sub SaveSettings {
foreach my $name (@setting_list) {
next if ! ($settings->{$name}->{'is_enabled'});
my $value = $cgi->param($name);
+ next unless defined $value;
my $setting = new Bugzilla::User::Setting($name);
if ($value eq "${name}-isdefault" ) {