diff options
| author | mkanat%bugzilla.org <> | 2006-07-06 08:33:25 +0200 |
|---|---|---|
| committer | mkanat%bugzilla.org <> | 2006-07-06 08:33:25 +0200 |
| commit | 1369edc78cf84ba2a3cebec0a5c7ae519175de9d (patch) | |
| tree | 81506588c5cf3ce70b0813faf0c00d499b4a09e9 | |
| parent | 704d78caa8d010776e646b3d3a26ef52e29cbbb4 (diff) | |
| download | bugzilla-1369edc78cf84ba2a3cebec0a5c7ae519175de9d.tar.gz bugzilla-1369edc78cf84ba2a3cebec0a5c7ae519175de9d.tar.xz | |
Bug 343361: die_with_dignity is useless inside of Bugzilla::CGI
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=colin, a=myk
| -rw-r--r-- | Bugzilla.pm | 13 | ||||
| -rw-r--r-- | Bugzilla/CGI.pm | 12 |
2 files changed, 13 insertions, 12 deletions
diff --git a/Bugzilla.pm b/Bugzilla.pm index 0d6e6af7d..e22ab97bf 100644 --- a/Bugzilla.pm +++ b/Bugzilla.pm @@ -61,6 +61,19 @@ use constant SHUTDOWNHTML_EXIT_SILENTLY => [ # Global Code ##################################################################### +# The following subroutine is for debugging purposes only. +# Uncommenting this sub and the $::SIG{__DIE__} trap underneath it will +# cause any fatal errors to result in a call stack trace to help track +# down weird errors. +# +#sub die_with_dignity { +# use Carp (); +# my ($err_msg) = @_; +# print $err_msg; +# Carp::confess($err_msg); +#} +#$::SIG{__DIE__} = \&Bugzilla::die_with_dignity; + # Some environment variables are not taint safe delete @::ENV{'PATH', 'IFS', 'CDPATH', 'ENV', 'BASH_ENV'}; diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index 688878b19..b4bcf20c8 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -50,18 +50,6 @@ $| = 1; $::SIG{TERM} = 'IGNORE'; $::SIG{PIPE} = 'IGNORE'; -# The following subroutine is for debugging purposes only. -# Uncommenting this sub and the $::SIG{__DIE__} trap underneath it will -# cause any fatal errors to result in a call stack trace to help track -# down weird errors. -#sub die_with_dignity { -# use Carp; # for confess() -# my ($err_msg) = @_; -# print $err_msg; -# confess($err_msg); -#} -#$::SIG{__DIE__} = \&die_with_dignity; - # CGI.pm uses AUTOLOAD, but explicitly defines a DESTROY sub. # We need to do so, too, otherwise perl dies when the object is destroyed # and we don't have a DESTROY method (because CGI.pm's AUTOLOAD will |die| |