diff options
| author | David Lawrence <dkl@mozilla.com> | 2016-06-30 23:10:14 +0200 |
|---|---|---|
| committer | David Lawrence <dkl@mozilla.com> | 2016-06-30 23:10:19 +0200 |
| commit | 19e2b191ef01b2e360ec8d0f0277e457fb7deb22 (patch) | |
| tree | 33890c3f028cb5826dfe03f8d2bd9fcfd862d601 | |
| parent | 7697add121a0f50342701ff5df411a43ff614853 (diff) | |
| download | bugzilla-19e2b191ef01b2e360ec8d0f0277e457fb7deb22.tar.gz bugzilla-19e2b191ef01b2e360ec8d0f0277e457fb7deb22.tar.xz | |
Bug 1279878 - CSV injection
| -rw-r--r-- | Bugzilla/Template.pm | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index 1ac88b62e..b03817793 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -863,12 +863,13 @@ sub create { }, # In CSV, quotes are doubled, and any value containing a quote or a - # comma is enclosed in quotes. If a field starts with an equals - # sign, it is proceed by a space. + # comma is enclosed in quotes. + # If a field starts with either "=", "+", "-" or "@", it is preceded + # by a space to prevent stupid formula execution from Excel & co. csv => sub { my ($var) = @_; - $var = ' ' . $var if substr($var, 0, 1) eq '='; + $var = ' ' . $var if $var =~ /^[+=@-]/; # backslash is not special to CSV, but it can be used to confuse some browsers... # so we do not allow it to happen. We only do this for logged-in users. $var =~ s/\\/\x{FF3C}/g if Bugzilla->user->id; |