summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2012-12-19 23:38:07 +0100
committerFrédéric Buclin <LpSolit@gmail.com>2012-12-19 23:38:07 +0100
commit3272176a7b37b3bd30ef376f7b782f736d207cd4 (patch)
tree5629c89e1e5546f8f1b765171d40f645f2356a98
parent387608caac85ccf6c0782572420ecbdae4e301bf (diff)
downloadbugzilla-3272176a7b37b3bd30ef376f7b782f736d207cd4.tar.gz
bugzilla-3272176a7b37b3bd30ef376f7b782f736d207cd4.tar.xz
Bug 819330: Bugzilla crashes when cloning a bug if the CC list is empty
r=dkl a=LpSolit
-rw-r--r--Bugzilla/Bug.pm2
-rw-r--r--Bugzilla/WebService/Bug.pm2
-rwxr-xr-xenter_bug.cgi2
3 files changed, 2 insertions, 4 deletions
diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 3506422ce..d912cd4ea 100644
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3199,8 +3199,6 @@ sub cc {
ORDER BY profiles.login_name},
undef, $self->bug_id);
- $self->{'cc'} = undef if !scalar(@{$self->{'cc'}});
-
return $self->{'cc'};
}
diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index a7f8446ec..709983389 100644
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -882,7 +882,7 @@ sub _bug_to_hash {
$item{'blocks'} = \@blocks;
}
if (filter_wants $params, 'cc') {
- my @cc = map { $self->type('email', $_) } @{ $bug->cc || [] };
+ my @cc = map { $self->type('email', $_) } @{ $bug->cc };
$item{'cc'} = \@cc;
}
if (filter_wants $params, 'creator') {
diff --git a/enter_bug.cgi b/enter_bug.cgi
index a4dde21ba..a609a2b9a 100755
--- a/enter_bug.cgi
+++ b/enter_bug.cgi
@@ -208,7 +208,7 @@ if ($cloned_bug_id) {
$vars->{'deadline'} = $cloned_bug->deadline;
$vars->{'estimated_time'} = $cloned_bug->estimated_time;
- if (defined $cloned_bug->cc) {
+ if (scalar @{$cloned_bug->cc}) {
$vars->{'cc'} = join (", ", @{$cloned_bug->cc});
} else {
$vars->{'cc'} = formvalue('cc');