Bug 300093: index.cgi remains unsecure when the SSL parameter is set to "authenticated sessions" - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave

2 files changed, 7 insertions, 1 deletions

diff --git a/index.cgi b/index.cgi
index bc3a1272f..694292fc7 100755
--- a/index.cgi
+++ b/index.cgi
@@ -43,6 +43,12 @@ Bugzilla->login(LOGIN_OPTIONAL);
 ###############################################################################
 
 my $cgi = Bugzilla->cgi;
+# Force to use HTTPS unless Param('ssl') equals 'never'.
+# This is required because the user may want to log in from here.
+if (Param('sslbase') ne '' and Param('ssl') ne 'never') {
+    $cgi->require_https(Param('sslbase'));
+}
+
 my $template = Bugzilla->template;
 
 # Return the appropriate HTTP response headers.
diff --git a/template/en/default/global/useful-links.html.tmpl b/template/en/default/global/useful-links.html.tmpl
index 5a01a5703..2ac89f91c 100644
--- a/template/en/default/global/useful-links.html.tmpl
+++ b/template/en/default/global/useful-links.html.tmpl
@@ -29,7 +29,7 @@
   <div id="links-actions">
     <div class="label">Actions:</div>
     <div class="links">
-        <a href="[% Param('urlbase') %]">Home</a> | 
+        <a href="./">Home</a> | 
         <a href="enter_bug.cgi">New</a> | 
         <a href="query.cgi">Search</a> |