summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2007-10-08 06:00:03 +0200
committerlpsolit%gmail.com <>2007-10-08 06:00:03 +0200
commit393cb39fdfefff8bba165d9076723bf7048198ef (patch)
treece6d83839de64f7977d91cf1d049af12dfdb1264
parentbbd35c12bf6b886a7768c4c6d43d8dca21f549aa (diff)
downloadbugzilla-393cb39fdfefff8bba165d9076723bf7048198ef.tar.gz
bugzilla-393cb39fdfefff8bba165d9076723bf7048198ef.tar.xz
Bug 398735: sanitycheck.cgi hardcodes bug statuses in the everconfirmed check - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
-rwxr-xr-xsanitycheck.cgi10
1 files changed, 5 insertions, 5 deletions
diff --git a/sanitycheck.cgi b/sanitycheck.cgi
index 157281b11..ef92256a2 100755
--- a/sanitycheck.cgi
+++ b/sanitycheck.cgi
@@ -874,11 +874,11 @@ Status('bug_check_status_everconfirmed');
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
'bug_check_status_everconfirmed_error_text');
-# The below list of resolutions is hard-coded because we don't know if future
-# resolutions will be confirmed, unconfirmed or maybeconfirmed. I suspect
-# they will be maybeconfirmed, e.g. ASLEEP and REMIND. This hardcoding should
-# disappear when we have customized statuses.
-BugCheck("bugs WHERE bug_status IN ('NEW', 'ASSIGNED', 'REOPENED') AND everconfirmed = 0",
+
+my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN;
+my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states);
+
+BugCheck("bugs WHERE bug_status IN ($confirmed_open_states) AND everconfirmed = 0",
'bug_check_status_everconfirmed_error_text2');
Status('bug_check_votes_everconfirmed');