Bug 141006: Run edit*.cgis in taint mode.

Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave

7 files changed, 8 insertions, 13 deletions

diff --git a/editcomponents.cgi b/editcomponents.cgi
index f57036665..4c00050fa 100755
--- a/editcomponents.cgi
+++ b/editcomponents.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
diff --git a/editmilestones.cgi b/editmilestones.cgi
index e5c8844bd..43cded1ea 100755
--- a/editmilestones.cgi
+++ b/editmilestones.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 
 #
diff --git a/editparams.cgi b/editparams.cgi
index aaa2b087a..8ffd76a08 100755
--- a/editparams.cgi
+++ b/editparams.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
diff --git a/editproducts.cgi b/editproducts.cgi
index 79fed4411..4fa2cb43d 100755
--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
diff --git a/editusers.cgi b/editusers.cgi
index aa760b1e1..abe4b6194 100755
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
diff --git a/editversions.cgi b/editversions.cgi
index 43fe45711..a3a2e2cc5 100755
--- a/editversions.cgi
+++ b/editversions.cgi
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/perl -wT
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public
diff --git a/t/002goodperl.t b/t/002goodperl.t
index 1cfb6a06f..92a01fc2d 100644
--- a/t/002goodperl.t
+++ b/t/002goodperl.t
@@ -59,13 +59,8 @@ foreach my $file (@testitems) {
             ok(0, "$file is a module, but has a shebang");
             next;
         } elsif ($ext eq "cgi") {
-            # cgi files must be taint checked, but only the user-accessible
-            # ones have been checked so far
-            if ($file =~ m/^edit/) {
-                $flags = "w";
-            } else {
-                $flags = "wT";
-            }
+            # cgi files must be taint checked
+            $flags = "wT";
         } else {
             ok(0, "$file has shebang but unknown extension");
             next;