summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2009-02-20 15:12:49 +0100
committerlpsolit%gmail.com <>2009-02-20 15:12:49 +0100
commit4192ccfd0318d1772df6ff58ad06966ddd0c5449 (patch)
tree3b14b20735ab063695921685bcba332c93da29e1
parent66d2c81c74cc028e205b1e53c093a63c2a281256 (diff)
downloadbugzilla-4192ccfd0318d1772df6ff58ad06966ddd0c5449.tar.gz
bugzilla-4192ccfd0318d1772df6ff58ad06966ddd0c5449.tar.xz
Bug 477459: buglist.cgi crashes for logged out users if the "Reporter" column is displayed - Patches by Frédéric Buclin <LpSolit@gmail.com> and Xiaoou <xiaoou.wu@oracle.com> r/a=mkanat
-rw-r--r--Bugzilla/DB.pm2
-rw-r--r--Bugzilla/DB/Oracle.pm2
2 files changed, 2 insertions, 2 deletions
diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index 81a720ee5..f7d00f3b3 100644
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -52,7 +52,7 @@ use Storable qw(dclone);
use constant BLOB_TYPE => DBI::SQL_BLOB;
use constant ISOLATION_LEVEL => 'REPEATABLE READ';
-use constant GROUPBY_REGEXP => '(?:.*\s+AS\s+)?(\w+(\.\w+)?)(?:\s+(ASC|DESC))?$';
+use constant GROUPBY_REGEXP => '(?:.*\s+AS\s+|SUBSTRING\()?(\w+(\.\w+)?)(?:\s+(ASC|DESC|FROM\s+.+))?$';
# Set default values for what used to be the enum types. These values
# are no longer stored in localconfig. If we are upgrading from a
diff --git a/Bugzilla/DB/Oracle.pm b/Bugzilla/DB/Oracle.pm
index ee150c024..83ece2a05 100644
--- a/Bugzilla/DB/Oracle.pm
+++ b/Bugzilla/DB/Oracle.pm
@@ -52,7 +52,7 @@ use base qw(Bugzilla::DB);
use constant EMPTY_STRING => '__BZ_EMPTY_STR__';
use constant ISOLATION_LEVEL => 'READ COMMITTED';
use constant BLOB_TYPE => { ora_type => ORA_BLOB };
-use constant GROUPBY_REGEXP => '((CASE\s+WHEN.+END)|(TO_CHAR\(.+\))|(\(SCORE.+\))|(\(MATCH.+\))|(\w+(\.\w+)?))(\s+AS\s+)?(.*)?$';
+use constant GROUPBY_REGEXP => '((CASE\s+WHEN.+END)|(SUBSTR.+\))|(TO_CHAR\(.+\))|(\(SCORE.+\))|(\(MATCH.+\))|(\w+(\.\w+)?))(\s+AS\s+)?(.*)?$';
sub new {
my ($class, $user, $pass, $host, $dbname, $port) = @_;