summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjustdave%syndicomm.com <>2001-11-08 12:38:12 +0100
committerjustdave%syndicomm.com <>2001-11-08 12:38:12 +0100
commit5e6e016a375c27115f7b9c647e2dbc03b403c9e9 (patch)
tree193131aa85b21e6d8bcc0033b9dab6752c7500d2
parent8e63a96f66bd6326fb5446ae74e6d864fc22a3bf (diff)
downloadbugzilla-5e6e016a375c27115f7b9c647e2dbc03b403c9e9.tar.gz
bugzilla-5e6e016a375c27115f7b9c647e2dbc03b403c9e9.tar.xz
Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
bug itself was not always being updated if dependencies or CCs changed. Patch by Dave Miller <justdave@syndicomm.com> r= bbaetz, jake
-rwxr-xr-xprocess_bug.cgi14
1 files changed, 8 insertions, 6 deletions
diff --git a/process_bug.cgi b/process_bug.cgi
index 30f604c07..7f3d32098 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -863,6 +863,7 @@ sub SnapShotDeps {
my $timestamp;
+my $bug_changed;
sub FindWrapPoint {
my ($string, $startpos) = @_;
@@ -912,7 +913,8 @@ sub LogActivityEntry {
my $fieldid = GetFieldID($col);
SendSQL("INSERT INTO bugs_activity " .
"(bug_id,who,bug_when,fieldid,removed,added) VALUES " .
- "($i,$whoid,$timestamp,$fieldid,$removestr,$addstr)");
+ "($i,$whoid," . SqlQuote($timestamp) . ",$fieldid,$removestr,$addstr)");
+ $bug_changed = 1;
}
}
@@ -934,6 +936,7 @@ sub LogDependencyActivity {
#
foreach my $id (@idlist) {
my %dependencychanged;
+ $bug_changed = 0;
my $write = "WRITE"; # Might want to make a param to control
# whether we do LOW_PRIORITY ...
SendSQL("LOCK TABLES bugs $write, bugs_activity $write, cc $write, " .
@@ -1116,17 +1119,14 @@ The changes made were:
" WHERE bug_id = $id");
}
}
-
my $query = "$basequery\nwhere bug_id = $id";
# print "<PRE>$query</PRE>\n";
if ($::comma ne "") {
SendSQL($query);
- SendSQL("select delta_ts from bugs where bug_id = $id");
- } else {
- SendSQL("select now()");
}
+ SendSQL("select now()");
$timestamp = FetchOneColumn();
if (defined $::FORM{'comment'}) {
@@ -1339,7 +1339,9 @@ The changes made were:
LogActivityEntry($id,$col,$old,$new);
}
}
-
+ if ($bug_changed) {
+ SendSQL("UPDATE bugs SET delta_ts = " . SqlQuote($timestamp) . " WHERE bug_id = $id");
+ }
print "<TABLE BORDER=1><TD><H2>Changes to bug $id submitted</H2>\n";
SendSQL("unlock tables");