Bug 297593: defaultpriority, defaultseverity, defaultplatform and defaultopsys parameters in editparams.cgi should be a dropdown menu - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave

2 files changed, 18 insertions, 12 deletions

diff --git a/Bugzilla/Config/BugFields.pm b/Bugzilla/Config/BugFields.pm
index 6c942568f..17b79941d 100644
--- a/Bugzilla/Config/BugFields.pm
+++ b/Bugzilla/Config/BugFields.pm
@@ -84,30 +84,34 @@ sub get_param_list {
 
   {
    name => 'defaultpriority',
-   type => 't',
-   default => 'P2',
+   type => 's',
+   choices => \@::legal_priority,
+   default => $::legal_priority[-1],
    checker => \&check_priority
   },
 
   {
    name => 'defaultseverity',
-   type => 't',
-   default => 'normal',
+   type => 's',
+   choices => \@::legal_severity,
+   default => $::legal_severity[-1],
    checker => \&check_severity
   },
 
   {
-    name => 'defaultplatform',
-    type => 't',
-    default => '',
-    checker => \&check_platform
+   name => 'defaultplatform',
+   type => 's',
+   choices => ['', @::legal_platform],
+   default => '',
+   checker => \&check_platform
   },
 
   {
-    name => 'defaultopsys',
-    type => 't',
-    default => '',
-    checker => \&check_opsys
+   name => 'defaultopsys',
+   type => 's',
+   choices => ['', @::legal_opsys],
+   default => '',
+   checker => \&check_opsys
   } );
   return @param_list;
 }
diff --git a/editparams.cgi b/editparams.cgi
index 54d3a3a0a..1aa52d81a 100755
--- a/editparams.cgi
+++ b/editparams.cgi
@@ -48,6 +48,8 @@ my $current_panel = $cgi->param('section') || 'core';
 $current_panel =~ /^([A-Za-z0-9_-]+)$/;
 $current_panel = $1;
 
+GetVersionTable();
+
 my $current_module;
 my @panels = ();
 foreach my $panel (@parampanels) {