summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjocuri%softhome.net <>2004-03-06 18:08:46 +0100
committerjocuri%softhome.net <>2004-03-06 18:08:46 +0100
commit6b975d4ec50ac91be0d01537792d33b7c8197941 (patch)
tree350fbc0c24a6c11e9d8812d284c076afd7c6bbb5
parentd0050300d371b559e7da0e3200c967bd08c7e8c4 (diff)
downloadbugzilla-6b975d4ec50ac91be0d01537792d33b7c8197941.tar.gz
bugzilla-6b975d4ec50ac91be0d01537792d33b7c8197941.tar.xz
Patch for bug 234875: use ->param in quips.cgi; r=kiko, a=justdave.
-rwxr-xr-xquips.cgi8
1 files changed, 4 insertions, 4 deletions
diff --git a/quips.cgi b/quips.cgi
index 4559e7b91..bf1c41450 100755
--- a/quips.cgi
+++ b/quips.cgi
@@ -45,7 +45,7 @@ if (Param('enablequips') eq "off") {
ThrowUserError("quips_disabled");
}
-my $action = $::FORM{'action'} || "";
+my $action = $cgi->param('action') || "";
if ($action eq "show") {
# Read in the entire quip list
@@ -81,7 +81,7 @@ if ($action eq "add") {
# Add the quip
my $approved = (Param('enablequips') eq "on") ? '1' : '0';
$approved = 1 if(UserInGroup('admin'));
- my $comment = $::FORM{"quip"};
+ my $comment = $cgi->param("quip");
$comment || ThrowUserError("need_quip");
$comment !~ m/</ || ThrowUserError("no_html_in_quips");
@@ -104,7 +104,7 @@ if ($action eq 'approve') {
my @approved;
my @unapproved;
foreach my $quipid (keys %quips) {
- my $form = ($::FORM{'quipid_'.$quipid}) ? 1 : 0;
+ my $form = $cgi->param('quipid_'.$quipid) ? 1 : 0;
if($quips{$quipid} ne $form) {
if($form) { push(@approved, $quipid); }
else { push(@unapproved, $quipid); }
@@ -122,7 +122,7 @@ if ($action eq "delete") {
if (!UserInGroup('admin')) {
ThrowUserError("quips_edit_denied");
}
- my $quipid = $::FORM{"quipid"};
+ my $quipid = $cgi->param("quipid");
ThrowCodeError("need_quipid") unless $quipid =~ /(\d+)/;
$quipid = $1;