diff options
author | Matt Selsky <selsky@columbia.edu> | 2011-02-14 03:00:40 +0100 |
---|---|---|
committer | Reed Loden <reed@reedloden.com> | 2011-02-14 03:00:40 +0100 |
commit | 6d3b841922c630174db846a3ab133c2dcaf5a63e (patch) | |
tree | 73e6e33e9e15f0f9daed03e28acaa2f94a99316a | |
parent | fb5f96302e408d10d56167f3e185675e6cffd6d1 (diff) | |
download | bugzilla-6d3b841922c630174db846a3ab133c2dcaf5a63e.tar.gz bugzilla-6d3b841922c630174db846a3ab133c2dcaf5a63e.tar.xz |
Bug 543667: Add support for Trac URLs in "see also".
-rw-r--r-- | Bugzilla/BugUrl.pm | 1 | ||||
-rw-r--r-- | Bugzilla/BugUrl/Trac.pm | 54 | ||||
-rw-r--r-- | template/en/default/global/user-error.html.tmpl | 1 |
3 files changed, 56 insertions, 0 deletions
diff --git a/Bugzilla/BugUrl.pm b/Bugzilla/BugUrl.pm index 17a3e9333..4c22d0612 100644 --- a/Bugzilla/BugUrl.pm +++ b/Bugzilla/BugUrl.pm @@ -62,6 +62,7 @@ use constant SUB_CLASSES => qw( Bugzilla::BugUrl::Google Bugzilla::BugUrl::Debian Bugzilla::BugUrl::JIRA + Bugzilla::BugUrl::Trac ); ############################### diff --git a/Bugzilla/BugUrl/Trac.pm b/Bugzilla/BugUrl/Trac.pm new file mode 100644 index 000000000..638bd779e --- /dev/null +++ b/Bugzilla/BugUrl/Trac.pm @@ -0,0 +1,54 @@ +# -*- Mode: perl; indent-tabs-mode: nil -*- +# +# The contents of this file are subject to the Mozilla Public +# License Version 1.1 (the "License"); you may not use this file +# except in compliance with the License. You may obtain a copy of +# the License at http://www.mozilla.org/MPL/ +# +# Software distributed under the License is distributed on an "AS +# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or +# implied. See the License for the specific language governing +# rights and limitations under the License. +# +# The Original Code is the Bugzilla Bug Tracking System. +# +# The Initial Developer of the Original Code is Matt Selsky +# Portions created by Matt Selsky are Copyright (C) 2010 +# Matt Selsky. All Rights Reserved. +# +# Contributor(s): Matt Selsky <selsky@columbia.edu> + +package Bugzilla::BugUrl::Trac; +use strict; +use base qw(Bugzilla::BugUrl); + +use Bugzilla::Error; +use Bugzilla::Util; + +############################### +#### Methods #### +############################### + +sub should_handle { + my ($class, $uri) = @_; + return ($uri->path =~ m|/ticket/\d+$|) ? 1 : 0; +} + +sub _check_value { + my $class = shift; + + my $uri = $class->SUPER::_check_value(@_); + + # Trac URLs can look like various things: + # http://dev.mutt.org/trac/ticket/1234 + # http://trac.roundcube.net/ticket/1484130 + + # Make sure there are no query parameters. + $uri->query(undef); + # And remove any # part if there is one. + $uri->fragment(undef); + + return $uri; +} + +1; diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl index 69394bec9..0c345f359 100644 --- a/template/en/default/global/user-error.html.tmpl +++ b/template/en/default/global/user-error.html.tmpl @@ -256,6 +256,7 @@ <li>An issue on code.google.com.</li> <li>A b[% %]ug on b[% %]ugs.debian.org.</li> <li>An issue in a JIRA installation.</li> + <li>A ticket in a Trac installation.</li> </ul> [% ELSIF reason == 'id' %] There is no valid [% terms.bug %] id in that URL. |