Additional fix for bug 87770: attachment.cgi should work with no

parameters. Use <button> tags to allow for localization of the labels.
r=myk, a=myk.

I padded the Edit button with &nbsp;s to ensure it has the same width as
the View button; it may not be kosher but passes as visually agreeable,
at least.

2 files changed, 2 insertions, 11 deletions

diff --git a/attachment.cgi b/attachment.cgi
index d851e537e..67e8559c4 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -76,15 +76,6 @@ my $cgi = Bugzilla->cgi;
 # Determine whether to use the action specified by the user or the default.
 my $action = $::FORM{'action'} || 'view';
 
-# Slight awkward extra checks for the case when we came here from the
-# attachment/choose.html.tmpl page
-if ($action eq 'View') {
-    $action = 'view';
-}
-elsif ($action eq 'Edit') {
-    $action = 'edit';
-}
-
 if ($action eq "view")  
 {
   validateID();
diff --git a/template/en/default/attachment/choose.html.tmpl b/template/en/default/attachment/choose.html.tmpl
index b48664653..628dafb96 100644
--- a/template/en/default/attachment/choose.html.tmpl
+++ b/template/en/default/attachment/choose.html.tmpl
@@ -28,8 +28,8 @@
 <form method="get" action="attachment.cgi">
   <p>Access an attachment by entering its ID into the form below:</p>
   <p>Attachment ID: <input name="id" size="6">
-  <input type="submit" name="action" value="Edit">
-  <input type="submit" name="action" value="View">
+  <button name="action" value="edit">&nbsp;Edit&nbsp;</button>
+  <button name="action" value="view">View</button>
   </p>
 </form>