summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorByron Jones <glob@mozilla.com>2015-07-15 07:22:23 +0200
committerByron Jones <glob@mozilla.com>2015-07-15 07:22:23 +0200
commit7a87266845224adb56547f775ddbb01914a73d7f (patch)
tree56f7b80d9848914e8d1d948449951519943d13a8
parent2bd3296eaa42479b1dd0aa5c12a442a86140b02c (diff)
downloadbugzilla-7a87266845224adb56547f775ddbb01914a73d7f.tar.gz
bugzilla-7a87266845224adb56547f775ddbb01914a73d7f.tar.xz
Bug 1183976 - Use of uninitialized value $name in hash element at extensions/InlineHistory/Extension.pm
-rw-r--r--extensions/BugModal/lib/ActivityStream.pm2
-rw-r--r--extensions/InlineHistory/Extension.pm2
2 files changed, 4 insertions, 0 deletions
diff --git a/extensions/BugModal/lib/ActivityStream.pm b/extensions/BugModal/lib/ActivityStream.pm
index 82be3ff53..b25bff861 100644
--- a/extensions/BugModal/lib/ActivityStream.pm
+++ b/extensions/BugModal/lib/ActivityStream.pm
@@ -245,11 +245,13 @@ sub _add_activities_to_stream {
my %flags;
foreach my $added (@added) {
my ($value, $name) = $added =~ /^((.+).)$/;
+ next unless defined $name;
$flags{$name}{added} = $value;
$flags{$name}{removed} |= '';
}
foreach my $removed (@removed) {
my ($value, $name) = $removed =~ /^((.+).)$/;
+ next unless defined $name;
$flags{$name}{added} |= '';
$flags{$name}{removed} = $value;
}
diff --git a/extensions/InlineHistory/Extension.pm b/extensions/InlineHistory/Extension.pm
index c48405eb9..86536719f 100644
--- a/extensions/InlineHistory/Extension.pm
+++ b/extensions/InlineHistory/Extension.pm
@@ -155,11 +155,13 @@ sub template_before_process {
my %flags;
foreach my $added (@added) {
my ($value, $name) = $added =~ /^((.+).)$/;
+ next unless defined $name;
$flags{$name}{added} = $value;
$flags{$name}{removed} |= '';
}
foreach my $removed (@removed) {
my ($value, $name) = $removed =~ /^((.+).)$/;
+ next unless defined $name;
$flags{$name}{added} |= '';
$flags{$name}{removed} = $value;
}