Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk

2 files changed, 5 insertions, 2 deletions

diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index 10cbcd0d0..765ad9afa 100644
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -447,6 +447,9 @@ sub update_activity {
                   (bug_id, attach_id, who, bug_when, fieldid, removed, added)
                   VALUES ($bug_id, $attach_id, $::userid, $timestamp,
                   $field_id, $sql_removed, $sql_added)");
+
+        $dbh->do("UPDATE bugs SET delta_ts = $timestamp WHERE bug_id = ?",
+                 undef, $bug_id);
     }
 }
 
diff --git a/attachment.cgi b/attachment.cgi
index 8b9bdaafd..33f35b69f 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -1156,7 +1156,7 @@ sub update
           # Bugzilla::User needs to rederive groups. profiles and 
           # user_group_map would be READ locks instead of WRITE locks if it
           # weren't for derive_groups, which needs to write to those tables.
-          'bugs READ', 'profiles WRITE', 'email_setting READ',
+          'bugs WRITE', 'profiles WRITE', 'email_setting READ',
           'cc READ', 'bug_group_map READ', 'user_group_map WRITE',
           'group_group_map READ', 'groups READ');
 
@@ -1251,7 +1251,7 @@ sub update
 
   # If the user submitted a comment while editing the attachment,
   # add the comment to the bug.
-  if (defined $cgi->param('comment'))
+  if ($cgi->param('comment'))
   {
     # Prepend a string to the comment to let users know that the comment came
     # from the "edit attachment" screen.