summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbbaetz%student.usyd.edu.au <>2002-06-23 09:46:08 +0200
committerbbaetz%student.usyd.edu.au <>2002-06-23 09:46:08 +0200
commit827b828164394eb38ed4ef5eb0df99e8797021b1 (patch)
tree254e9b880bd65a6d86ce5bff0bb478a9d780b324
parent106f715776c58f3f128cb12c7bb5c1f0a6d42b49 (diff)
downloadbugzilla-827b828164394eb38ed4ef5eb0df99e8797021b1.tar.gz
bugzilla-827b828164394eb38ed4ef5eb0df99e8797021b1.tar.xz
Bug 150153 - ConnectToDatabase/quietly_check_login issues pt 2
r=jouni x2
-rw-r--r--CGI.pl2
-rw-r--r--globals.pl6
2 files changed, 0 insertions, 8 deletions
diff --git a/CGI.pl b/CGI.pl
index 04a683a47..ea305db53 100644
--- a/CGI.pl
+++ b/CGI.pl
@@ -442,7 +442,6 @@ sub quietly_check_login() {
$::userid = 0;
if (defined $::COOKIE{"Bugzilla_login"} &&
defined $::COOKIE{"Bugzilla_logincookie"}) {
- ConnectToDatabase();
SendSQL("SELECT profiles.userid, profiles.groupset, " .
"profiles.login_name, " .
"profiles.login_name = " .
@@ -559,7 +558,6 @@ sub confirm_login {
# Uncommenting the next line can help debugging...
# print "Content-type: text/plain\n\n";
- ConnectToDatabase();
# I'm going to reorganize some of this stuff a bit. Since we're adding
# a second possible validation method (LDAP), we need to move some of this
# to a later section. -Joe Robins, 8/3/00
diff --git a/globals.pl b/globals.pl
index 4f93820ff..f32fc1f3d 100644
--- a/globals.pl
+++ b/globals.pl
@@ -438,7 +438,6 @@ sub GenerateArrayCode {
sub GenerateVersionTable {
- ConnectToDatabase();
SendSQL("select value, program from versions order by value");
my @line;
my %varray;
@@ -1251,7 +1250,6 @@ sub UserInGroup {
if ($::usergroupset eq "0") {
return 0;
}
- ConnectToDatabase();
PushGlobalSQLState();
SendSQL("select (bit & $::usergroupset) != 0 from groups where name = " . SqlQuote($groupname));
my $bit = FetchOneColumn();
@@ -1274,7 +1272,6 @@ sub BugInGroup {
sub GroupExists {
my ($groupname) = (@_);
- ConnectToDatabase();
PushGlobalSQLState();
SendSQL("select count(*) from groups where name=" . SqlQuote($groupname));
my $count = FetchOneColumn();
@@ -1287,7 +1284,6 @@ sub GroupExists {
# !!! Remove this function when the new group system is implemented!
sub GroupNameToBit {
my ($groupname) = (@_);
- ConnectToDatabase();
PushGlobalSQLState();
SendSQL("SELECT bit FROM groups WHERE name = " . SqlQuote($groupname));
my $bit = FetchOneColumn() || 0;
@@ -1301,7 +1297,6 @@ sub GroupNameToBit {
sub GroupIsActive {
my ($groupbit) = (@_);
$groupbit ||= 0;
- ConnectToDatabase();
PushGlobalSQLState();
SendSQL("select isactive from groups where bit=$groupbit");
my $isactive = FetchOneColumn();
@@ -1331,7 +1326,6 @@ sub OpenStates {
sub RemoveVotes {
my ($id, $who, $reason) = (@_);
- ConnectToDatabase();
my $whopart = "";
if ($who) {
$whopart = " AND votes.who = $who";