summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbugreport%peshkin.net <>2002-11-25 14:38:08 +0100
committerbugreport%peshkin.net <>2002-11-25 14:38:08 +0100
commit9c07e003b12869792fdad5637e4f76789ffdaf2e (patch)
treee7cc501b4d2390bb18e915269a9f11bf4f24fc2f
parent8d94367316de4ab473ff117859e0fa6613e56518 (diff)
downloadbugzilla-9c07e003b12869792fdad5637e4f76789ffdaf2e.tar.gz
bugzilla-9c07e003b12869792fdad5637e4f76789ffdaf2e.tar.xz
Bug 180460 request.cgi doesn't filter list of products/components
patch by joel r=bbaetz a=justdave
-rw-r--r--globals.pl45
-rwxr-xr-xrequest.cgi7
2 files changed, 49 insertions, 3 deletions
diff --git a/globals.pl b/globals.pl
index 9d4372d00..07e9804c2 100644
--- a/globals.pl
+++ b/globals.pl
@@ -795,6 +795,51 @@ sub GetEnterableProducts {
return (@products);
}
+# GetEnterableProductHash
+# returns a hash containing
+# legal_products => an enterable product list
+# legal_components => the list of components of enterable products
+# components => a hash of component lists for each enterable product
+sub GetEnterableProductHash {
+ my $query = "SELECT products.name, components.name " .
+ "FROM products " .
+ "LEFT JOIN components " .
+ "ON components.product_id = products.id " .
+ "LEFT JOIN group_control_map " .
+ "ON group_control_map.product_id = products.id " .
+ "AND group_control_map.entry != 0 ";
+ if ((defined @{$::vars->{user}{groupids}})
+ && (@{$::vars->{user}{groupids}} > 0)) {
+ $query .= "AND group_id NOT IN(" .
+ join(',', @{$::vars->{user}{groupids}}) . ") ";
+ }
+ $query .= "WHERE group_id IS NULL " .
+ "ORDER BY products.name, components.name";
+ PushGlobalSQLState();
+ SendSQL($query);
+ my @products = ();
+ my %components = ();
+ my %components_by_product = ();
+ while (MoreSQLData()) {
+ my ($product, $component) = FetchSQLData();
+ if (!grep($_ eq $product, @products)) {
+ push @products, $product;
+ }
+ if ($component) {
+ $components{$component} = 1;
+ push @{$components_by_product{$product}}, $component;
+ }
+ }
+ PopGlobalSQLState();
+ my @componentlist = (sort keys %components);
+ return {
+ legal_products => \@products,
+ legal_components => \@componentlist,
+ components => \%components_by_product,
+ };
+}
+
+
sub CanSeeBug {
my ($id, $userid) = @_;
diff --git a/request.cgi b/request.cgi
index c2dbae81e..c74e97e64 100755
--- a/request.cgi
+++ b/request.cgi
@@ -254,9 +254,10 @@ sub queue {
# menu when the products menu changes; used by the template to populate
# the menus and keep the components menu consistent with the products menu
GetVersionTable();
- $vars->{'products'} = \@::legal_product;
- $vars->{'components'} = \@::legal_components;
- $vars->{'components_by_product'} = \%::components;
+ my $enterable = GetEnterableProductHash();
+ $vars->{'products'} = $enterable->{legal_products};
+ $vars->{'components'} = $enterable->{legal_components};
+ $vars->{'components_by_product'} = $enterable->{components};
$vars->{'excluded_columns'} = \@excluded_columns;
$vars->{'group_field'} = $::FORM{'group'};