diff options
| author | bryce-mozilla%nextbus.com <> | 1999-06-15 13:25:28 +0200 |
|---|---|---|
| committer | bryce-mozilla%nextbus.com <> | 1999-06-15 13:25:28 +0200 |
| commit | a59f318781f4f189484ba21206119c36ef3becf8 (patch) | |
| tree | 1a2385d83a124ad8fa0973933d5903c26301486a | |
| parent | 991e9d13f2bf7f7dafde5fc602b1612a3f88943c (diff) | |
| download | bugzilla-a59f318781f4f189484ba21206119c36ef3becf8.tar.gz bugzilla-a59f318781f4f189484ba21206119c36ef3becf8.tar.xz | |
Fix several browsers, Lynx and Opera at least. HTML syntax errors here
and there were fixed, and serverpush was restricted only to the versions
of Mozilla known to support it.
| -rw-r--r-- | bug_form.pl | 9 | ||||
| -rwxr-xr-x | buglist.cgi | 19 | ||||
| -rwxr-xr-x | query.cgi | 4 | ||||
| -rwxr-xr-x | show_bug.cgi | 3 |
4 files changed, 16 insertions, 19 deletions
diff --git a/bug_form.pl b/bug_form.pl index a2fb1056b..9a59ed94d 100644 --- a/bug_form.pl +++ b/bug_form.pl @@ -207,8 +207,6 @@ if (defined $URL && $URL ne "none" && $URL ne "NULL" && $URL ne "") { } print " -<HEAD><TITLE>Bug $id -- " . html_quote($bug{'short_desc'}) . - "</TITLE></HEAD><BODY> <FORM NAME=changeform METHOD=POST ACTION=\"process_bug.cgi\"> <INPUT TYPE=HIDDEN NAME=\"delta_ts\" VALUE=\"$bug{'delta_ts'}\"> <INPUT TYPE=HIDDEN NAME=\"longdesclength\" VALUE=\"$longdesclength\"> @@ -323,7 +321,7 @@ while (MoreSQLData()) { print qq{<td><a href="$link">$date</a></td><td colspan=4>$desc</td></tr><tr><td></td>}; $knownattachments{$attachid} = 1; } -print "<td colspan=6><a href=createattachment.cgi?id=$id>Create a new attachment</a> (proposed patch, testcase, etc.)</td></tr></table>\n"; +print "<td colspan=6><a href=\"createattachment.cgi?id=$id\">Create a new attachment</a> (proposed patch, testcase, etc.)</td></tr></table>\n"; sub EmitDependList { @@ -458,7 +456,7 @@ print " <A HREF=\"long_list.cgi?buglist=$id\">Format For Printing</A> </B></FONT><BR> </FORM> -<table><tr><td align=left><B>Description:</B></td><td width=100%> </td> +<table><tr><td align=left><B>Description:</B></td><td width=\"100%\"> </td> <td align=right>Opened: $bug{'creation_ts'}</td></tr></table> <HR> <PRE> @@ -472,9 +470,6 @@ print " # long_list.cgi line: # <A HREF=\"edit_desc.cgi?id=$id\">Edit Long Description</A> - navigation_header(); -print "</BODY>\n"; - 1; diff --git a/buglist.cgi b/buglist.cgi index 19fc96940..2aae1de05 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -25,11 +25,13 @@ use strict; require "CGI.pl"; use Date::Parse; -my $serverpush = 1; +my $serverpush = 0; -if ($ENV{'HTTP_USER_AGENT'} =~ /MSIE/) { - # Internet explorer doesn't seem to understand server push. What fun. - $serverpush = 0; +if ($ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/ && $ENV{'HTTP_USER_AGENT'} !~ /[Cc]ompatible/ ) { + # Search for real Netscape 3 and up. http://www.browsercaps.org used as source of + # browsers compatbile with server-push. It's a Netscape hack, incompatbile + # with MSIE and Lynx (at least). + $serverpush = 1; } if ($serverpush) { @@ -121,11 +123,10 @@ Content-type: text/html <HTML> <TITLE>OK, default is set.</TITLE> -OK, you now have a new default query. +OK, you now have a new default query. You may also bookmark the result of any +individual query. -<P> - -<A HREF=query.cgi>Go back to the query page, using the new default.</A> +<P><A HREF=query.cgi>Go back to the query page, using the new default.</A> "; exit; }; @@ -821,7 +822,7 @@ if ($count > 0) { <A HREF=\"colchange.cgi?$::buffer\">Change columns</A> </FORM>"; if (!$dotweak && $count > 1) { - print "<A HREF=\"buglist.cgi?$fields&tweak=1\">Make changes to several of these bugs at once.</A>\n"; + print "<A HREF=\"buglist.cgi?$fields&tweak=1\">Change several bugs at once</A>\n"; } } if ($serverpush) { @@ -437,7 +437,7 @@ changed. <tr> <TH ALIGN=LEFT VALIGN=BOTTOM>Program:</th> <TH ALIGN=LEFT VALIGN=BOTTOM>Version:</th> -<TH ALIGN=LEFT VALIGN=BOTTOM><A HREF=describecomponents.cgi>Component:<a></th> +<TH ALIGN=LEFT VALIGN=BOTTOM><A HREF=describecomponents.cgi>Component:</a></th> "; if (Param("usetargetmilestone")) { @@ -509,7 +509,6 @@ print " </table> <table border=0> -<tr> "; StringSearch("Summary", "short_desc"); @@ -560,7 +559,6 @@ print " <INPUT TYPE=\"reset\" VALUE=\"Reset back to the default query\"> <INPUT TYPE=hidden name=form_name VALUE=query> <BR>Give me a <A HREF=\"help.html\">clue</A> about how to use this form. -</CENTER> </FORM> "; diff --git a/show_bug.cgi b/show_bug.cgi index b2e747297..927d52688 100755 --- a/show_bug.cgi +++ b/show_bug.cgi @@ -52,3 +52,6 @@ print "<HR>\n"; $! = 0; do "bug_form.pl" || die "Error doing bug_form.pl: $!"; +print "</BODY>"; +print "</HTML>\n"; + |