summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorguy.pyrzak%gmail.com <>2009-01-23 22:08:13 +0100
committerguy.pyrzak%gmail.com <>2009-01-23 22:08:13 +0100
commita77cbd2028075fd0cb2acd7d60a113f7e5248e14 (patch)
treedd4ff60fb10cb22e31373571956d12737f7f6da3
parentaff82a963b8ef1561b346eea5627ee189ce405f8 (diff)
downloadbugzilla-a77cbd2028075fd0cb2acd7d60a113f7e5248e14.tar.gz
bugzilla-a77cbd2028075fd0cb2acd7d60a113f7e5248e14.tar.xz
Bug 471518: "Field only appears when:" produces a JavaScript error in Internet Explorer
Patch By Jill Foley <jillpf55@sbcglobal.net> r=mkanat, a=mkanat
-rw-r--r--js/util.js2
-rw-r--r--template/en/default/admin/custom_fields/cf-js.js.tmpl2
2 files changed, 2 insertions, 2 deletions
diff --git a/js/util.js b/js/util.js
index 86924210c..8e787847a 100644
--- a/js/util.js
+++ b/js/util.js
@@ -166,7 +166,7 @@ function bz_isValueInArray(aArray, aValue)
*/
function bz_createOptionInSelect(aSelect, aTextValue, aValue) {
var myOption = new Option(aTextValue, aValue);
- aSelect.appendChild(myOption);
+ aSelect.options[aSelect.length] = myOption;
return myOption;
}
diff --git a/template/en/default/admin/custom_fields/cf-js.js.tmpl b/template/en/default/admin/custom_fields/cf-js.js.tmpl
index 6c5bbf626..891f5da76 100644
--- a/template/en/default/admin/custom_fields/cf-js.js.tmpl
+++ b/template/en/default/admin/custom_fields/cf-js.js.tmpl
@@ -27,7 +27,7 @@ var select_values = new Array();
[% FOREACH sel_field = Bugzilla.get_fields({ is_select => 1 }) %]
select_values[[% sel_field.id FILTER js %]] = [
[% FOREACH legal_value = sel_field.legal_values %]
- [[% legal_value.id FILTER js %], '[% legal_value.name FILTER html %]'],
+ [[% legal_value.id FILTER js %], '[% legal_value.name FILTER html %]'][% ',' UNLESS loop.last %]
[% END %]
];
[% END %]