summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbugreport%peshkin.net <>2005-02-21 02:15:13 +0100
committerbugreport%peshkin.net <>2005-02-21 02:15:13 +0100
commitb6ddaf9809207f52a5f2ccefbb323eb92c887c8a (patch)
tree4894b4087d86dd0e2180f96a1e20f2cbd63a853d
parent30a52319c024fefb2b4e4aa7bd974e4af7af30cd (diff)
downloadbugzilla-b6ddaf9809207f52a5f2ccefbb323eb92c887c8a.tar.gz
bugzilla-b6ddaf9809207f52a5f2ccefbb323eb92c887c8a.tar.xz
Bug 282790: Warn if name for a stored query exceeds maximum length
patch by LpSolit r=mkanat,a=justdave
-rwxr-xr-xbuglist.cgi1
-rw-r--r--template/en/default/global/user-error.html.tmpl4
2 files changed, 5 insertions, 0 deletions
diff --git a/buglist.cgi b/buglist.cgi
index 4b9bc960f..fd01f10d5 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -239,6 +239,7 @@ sub InsertNamedQuery ($$$;$) {
# Validate the query name.
$query_name || ThrowUserError("query_name_missing");
$query_name !~ /[<>&]/ || ThrowUserError("illegal_query_name");
+ (length($query_name) <= 64) || ThrowUserError("query_name_too_long");
trick_taint($query_name);
detaint_natural($userid);
diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl
index ac2cba6d3..55c796924 100644
--- a/template/en/default/global/user-error.html.tmpl
+++ b/template/en/default/global/user-error.html.tmpl
@@ -862,6 +862,10 @@
[% title = "No Search Name Specified" %]
You must enter a name for your search.
+ [% ELSIF error == "query_name_too_long" %]
+ [% title = "Query Name Too Long" %]
+ The name of the query must be less than 64 characters long.
+
[% ELSIF error == "quips_disabled" %]
[% title = "Quips Disabled" %]
Quips are disabled.