summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorgerv%gerv.net <>2001-07-02 04:09:29 +0200
committergerv%gerv.net <>2001-07-02 04:09:29 +0200
commitd4d34ee53d2ca6c6a685006e0cd7ab5121e010dc (patch)
tree16a9f29e42ac4bf7012af631cb8a8e22525dca6f
parent092f07bfc3ff0259544f2dbd99d79868975f7167 (diff)
downloadbugzilla-d4d34ee53d2ca6c6a685006e0cd7ab5121e010dc.tar.gz
bugzilla-d4d34ee53d2ca6c6a685006e0cd7ab5121e010dc.tar.xz
Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake.
-rwxr-xr-xreports.cgi16
1 files changed, 3 insertions, 13 deletions
diff --git a/reports.cgi b/reports.cgi
index 163f583c8..c76a411f7 100755
--- a/reports.cgi
+++ b/reports.cgi
@@ -525,23 +525,13 @@ sub chart_image_type {
sub chart_image_name {
my ($data_file, $type) = @_;
- my $id = datasets_id($FORM{datasets});
- my $doy = day_of_year();
+ # Cache charts by generating a unique filename based on what they
+ # show. Charts should be deleted by collectstats.pl nightly.
+ my $id = join ("_", split (":", $FORM{datasets}));
return "${data_file}_${id}.$type";
}
-# Cache charts by generating a unique filename based on what they
-# show. Charts should be deleted by collectstats.pl nightly.
-sub datasets_id {
- # Current method is very long filenames...
- my $longname = "";
- foreach (@_) {
- $longname .= $_;
- }
- return $longname;
-}
-
sub day_of_year {
my ($mday, $month, $year) = (localtime())[3 .. 5];
$month += 1;