summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjocuri%softhome.net <>2004-03-20 07:03:52 +0100
committerjocuri%softhome.net <>2004-03-20 07:03:52 +0100
commitd9bcdba2ac385a91da5670bb33ca69711bdaaeda (patch)
tree77a53e96cb5b18cda642c0417fa15b607d9162f7
parentdffff7a2f6fad652c63813707412c85c843a1fcb (diff)
downloadbugzilla-d9bcdba2ac385a91da5670bb33ca69711bdaaeda.tar.gz
bugzilla-d9bcdba2ac385a91da5670bb33ca69711bdaaeda.tar.xz
Patch for bug 179351: improve variable scoping issues in order to fix a bug causing oddly formatted dependency emails; patch by Teemu Mannermaa <wicked@etlicon.fi> revised slightly by justdave; r=joel; a=justdave.
-rw-r--r--Bugzilla/BugMail.pm7
1 files changed, 3 insertions, 4 deletions
diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm
index fad3ad5d8..dc088c99c 100644
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -221,12 +221,11 @@ sub ProcessOneBug($) {
my $difftext = "";
my $diffheader = "";
- my $diffpart = {};
my @diffparts;
my $lastwho = "";
foreach my $ref (@diffs) {
my ($who, $what, $when, $old, $new, $attachid, $fieldname) = (@$ref);
- $diffpart = {};
+ my $diffpart = {};
if ($who ne $lastwho) {
$lastwho = $who;
$diffheader = "\n$who" . Param('emailsuffix') . " changed:\n\n";
@@ -301,8 +300,8 @@ sub ProcessOneBug($) {
$deptext = trim($deptext);
if ($deptext) {
- #$difftext = trim($difftext . "\n\n" . $deptext);
- $diffpart->{'text'} = trim("\n\n" . $deptext);
+ my $diffpart = {};
+ $diffpart->{'text'} = "\n" . trim("\n\n" . $deptext);
push(@diffparts, $diffpart);
}