diff options
| author | bugreport%peshkin.net <> | 2004-07-10 16:35:34 +0200 |
|---|---|---|
| committer | bugreport%peshkin.net <> | 2004-07-10 16:35:34 +0200 |
| commit | dbce51e838e74f1ad31e3d8076db93df64f56592 (patch) | |
| tree | 6108f6efb6c966cd8e4c7652872f242a306407f0 | |
| parent | 1ade641d4492138b0590c5717b47b429fff83d8a (diff) | |
| download | bugzilla-dbce51e838e74f1ad31e3d8076db93df64f56592.tar.gz bugzilla-dbce51e838e74f1ad31e3d8076db93df64f56592.tar.xz | |
Bug 227191: Change DBI->connect syntax so database password will not be revealed if connect fails
r=bbaetz
a=justdave
| -rw-r--r-- | Bugzilla/DB.pm | 6 | ||||
| -rwxr-xr-x | checksetup.pl | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm index a766a6e04..445e29500 100644 --- a/Bugzilla/DB.pm +++ b/Bugzilla/DB.pm @@ -144,10 +144,12 @@ sub _connect { # connect using our known info to the specified db # Apache::DBI will cache this when using mod_perl my $dbh = DBI->connect($dsn, - $db_user, - $db_pass, + '', + '', { RaiseError => 1, PrintError => 0, + Username => $db_user, + Password => $db_pass, ShowErrorStatement => 1, HandleError => \&_handle_error, FetchHashKeyName => 'NAME_lc', diff --git a/checksetup.pl b/checksetup.pl index c9ced42ec..2ccf0d8a4 100755 --- a/checksetup.pl +++ b/checksetup.pl @@ -246,7 +246,7 @@ my $modules = [ }, { name => 'DBI', - version => '1.32' + version => '1.36' }, { name => 'DBD::mysql', |