summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjocuri%softhome.net <>2004-10-25 08:34:20 +0200
committerjocuri%softhome.net <>2004-10-25 08:34:20 +0200
commite2b4bb1783928b8b10271ad415d17c2f080ca96f (patch)
tree2171fb30373c786601a33b179aceea7347feddfa
parentef6774469d8f5232bacb2266d469e57c63c3c689 (diff)
downloadbugzilla-e2b4bb1783928b8b10271ad415d17c2f080ca96f.tar.gz
bugzilla-e2b4bb1783928b8b10271ad415d17c2f080ca96f.tar.xz
Patch for bug 192218: Ability to use a hyphen as a way to filter specifically for requests with no requestee; patch by Frédéric Buclin <LpSolit@netscape.net>; r=myk, a=myk.
-rwxr-xr-xrequest.cgi6
-rw-r--r--template/en/default/request/queue.html.tmpl6
2 files changed, 8 insertions, 4 deletions
diff --git a/request.cgi b/request.cgi
index a494128d8..445783d47 100755
--- a/request.cgi
+++ b/request.cgi
@@ -151,8 +151,10 @@ sub queue {
push(@excluded_columns, 'requester') unless $cgi->param('do_union');
}
if (defined $cgi->param('requestee') && $cgi->param('requestee') ne "") {
- push(@criteria, "requestees.login_name = " .
- SqlQuote($cgi->param('requestee')));
+ if ($cgi->param('requestee') ne "-") {
+ push(@criteria, "requestees.login_name = " . SqlQuote($cgi->param('requestee')));
+ }
+ else { push(@criteria, "flags.requestee_id IS NULL") }
push(@excluded_columns, 'requestee') unless $cgi->param('do_union');
}
diff --git a/template/en/default/request/queue.html.tmpl b/template/en/default/request/queue.html.tmpl
index 0eb3f21cd..5a626b183 100644
--- a/template/en/default/request/queue.html.tmpl
+++ b/template/en/default/request/queue.html.tmpl
@@ -47,7 +47,8 @@
<table id="filter">
<tr>
<th>Requester:</th>
- <td><input type="text" name="requester" value="[% cgi.param('requester') FILTER html %]" size="20"></td>
+ <td><input type="text" name="requester" value="[% cgi.param('requester') FILTER html %]" size="20"
+ title="Requester's email address"></td>
<th>Product:</th>
<td>
<select name="product" onchange="selectProduct(this.form, 'product', 'component', 'Any');">
@@ -80,7 +81,8 @@
</tr>
<tr>
<th>Requestee:</th>
- <td><input type="text" name="requestee" value="[% cgi.param('requestee') FILTER html %]" size="20"></td>
+ <td><input type="text" name="requestee" value="[% cgi.param('requestee') FILTER html %]" size="20"
+ title="Requestee's email address or &quot;-&quot; (hyphen) for requests with no requestee"></td>
<th>Component:</th>
<td>
<select name="component">