summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2009-11-03 20:46:13 +0100
committerlpsolit%gmail.com <>2009-11-03 20:46:13 +0100
commited629ca0a2680ebeed503ca7d071fbf8ab8dfbec (patch)
tree700d0ae3029471f1f2f0a25bf51232055c5dd387
parente0deda7524d6389ecb93d291c4f6951039f1a086 (diff)
downloadbugzilla-ed629ca0a2680ebeed503ca7d071fbf8ab8dfbec.tar.gz
bugzilla-ed629ca0a2680ebeed503ca7d071fbf8ab8dfbec.tar.xz
Bug 526271: Uninitialized value in can_enter_product() due to a missing argument - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
-rw-r--r--Bugzilla/User.pm1
-rwxr-xr-xbuglist.cgi2
2 files changed, 2 insertions, 1 deletions
diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 9cb53fe34..3843062fb 100644
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -714,6 +714,7 @@ sub get_selectable_classifications {
sub can_enter_product {
my ($self, $input, $warn) = @_;
my $dbh = Bugzilla->dbh;
+ $warn ||= 0;
if (!defined $input) {
return unless $warn == THROW_ERROR;
diff --git a/buglist.cgi b/buglist.cgi
index 60713b035..a8103a1e0 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -1101,7 +1101,7 @@ elsif (my @product_input = $cgi->param('product')) {
}
# We only want the template to use it if the user can actually
# enter bugs against it.
-if (Bugzilla->user->can_enter_product($one_product)) {
+if ($one_product && Bugzilla->user->can_enter_product($one_product)) {
$vars->{'one_product'} = $one_product;
}