summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpreed%sigkill.com <>2003-02-15 17:29:26 +0100
committerpreed%sigkill.com <>2003-02-15 17:29:26 +0100
commitee88638a7dc3bad66049a69354d71816286073df (patch)
tree973f577e93fa30ca86526ad275b73b32cd677a1d
parentbdb93447f0a8b23db0bd7dfb0275c490b651f7ac (diff)
downloadbugzilla-ee88638a7dc3bad66049a69354d71816286073df.tar.gz
bugzilla-ee88638a7dc3bad66049a69354d71816286073df.tar.xz
Bug 192877 - State changes on bugs w/ dependancies cause "Use of uninitialized values" in BugMail.pm; r=justdave, bbaetz, a=justdave
-rw-r--r--Bugzilla/BugMail.pm15
1 files changed, 9 insertions, 6 deletions
diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm
index a71effcd2..e16a45139 100644
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -773,28 +773,31 @@ sub NewProcessOnePerson ($$$$$$$$$$$$$) {
my $difftext = "";
my $diffheader = "";
my $add_diff;
+
foreach my $diff (@diffparts) {
-
$add_diff = 0;
- if ($diff->{'fieldname'} eq 'estimated_time' ||
- $diff->{'fieldname'} eq 'remaining_time' ||
- $diff->{'fieldname'} eq 'work_time') {
+ if (exists($diff->{'fieldname'}) &&
+ ($diff->{'fieldname'} eq 'estimated_time' ||
+ $diff->{'fieldname'} eq 'remaining_time' ||
+ $diff->{'fieldname'} eq 'work_time')) {
if (UserInGroup(Param("timetrackinggroup"), $userid)) {
$add_diff = 1;
}
} else {
$add_diff = 1;
}
+
if ($add_diff) {
- if ($diffheader ne $diff->{'header'}) {
+ if (exists($diff->{'header'}) &&
+ ($diffheader ne $diff->{'header'})) {
$diffheader = $diff->{'header'};
$difftext .= $diffheader;
}
$difftext .= $diff->{'text'};
}
}
-
+
if ($difftext eq "" && $newcomments eq "") {
# Whoops, no differences!
return;