diff options
author | Byron Jones <glob@mozilla.com> | 2014-06-11 17:11:51 +0200 |
---|---|---|
committer | Byron Jones <glob@mozilla.com> | 2014-06-11 17:11:51 +0200 |
commit | 02719d27e660f1212450a563e0e0b8aefa6c6883 (patch) | |
tree | 52e06b9419833d016617b9039f61a939677fbc63 /Bugzilla/Attachment.pm | |
parent | 4d5e362475a95c83f478b846ed847ac5ebe31234 (diff) | |
download | bugzilla-02719d27e660f1212450a563e0e0b8aefa6c6883.tar.gz bugzilla-02719d27e660f1212450a563e0e0b8aefa6c6883.tar.xz |
Bug 978146: activity entry when setting flags isn't split across multiple rows
r=dkl,a=sgreen
Diffstat (limited to 'Bugzilla/Attachment.pm')
-rw-r--r-- | Bugzilla/Attachment.pm | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm index 79b7f1213..19c10c8fe 100644 --- a/Bugzilla/Attachment.pm +++ b/Bugzilla/Attachment.pm @@ -890,16 +890,12 @@ sub update { } # Record changes in the activity table. - my $sth = $dbh->prepare('INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when, - fieldid, removed, added) - VALUES (?, ?, ?, ?, ?, ?, ?)'); - + require Bugzilla::Bug; foreach my $field (keys %$changes) { my $change = $changes->{$field}; $field = "attachments.$field" unless $field eq "flagtypes.name"; - my $fieldid = get_field_id($field); - $sth->execute($self->bug_id, $self->id, $user->id, $timestamp, - $fieldid, $change->[0], $change->[1]); + Bugzilla::Bug::LogActivityEntry($self->bug_id, $field, $change->[0], + $change->[1], $user->id, $timestamp, undef, $self->id); } if (scalar(keys %$changes)) { |